From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 25 Jul 2025 11:42:46 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ufEww-003Xoq-2G for lore@lore.pengutronix.de; Fri, 25 Jul 2025 11:42:46 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1ufEww-0000sg-HV; Fri, 25 Jul 2025 11:42:46 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ufEwi-0000rk-SJ; Fri, 25 Jul 2025 11:42:32 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1ufEwi-00ACGg-00; Fri, 25 Jul 2025 11:42:32 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1ufEwh-009WTU-33; Fri, 25 Jul 2025 11:42:31 +0200 Date: Fri, 25 Jul 2025 11:42:31 +0200 From: Michael Olbrich To: Bruno Thomsen Message-ID: References: <20250716192255.4781-1-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] templates: update vim modeline for makefile and kconfig files X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: "ptxdist@pengutronix.de" , Markus Heidelberg Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Thu, Jul 24, 2025 at 11:35:34AM +0200, Bruno Thomsen wrote: > Den tors. 24. jul. 2025 kl. 09.51 skrev Markus Heidelberg : > > > > On Wed, Jul 23, 2025 at 07:03:42PM +0200, Bruno Thomsen wrote: > > > Den ons. 23. jul. 2025 kl. 09.11 skrev Michael Olbrich > > > : > > > > > > > > On Wed, Jul 16, 2025 at 09:22:55PM +0200, Bruno Thomsen wrote: > > > > > Setup sane editor default using vim modeline. > > > > > > > > > > sed -i "s/syntax=make/ft=make noet tw=72 ts=8 sw=8/g" rules/templates/*-make > > > > > > > > tw=72 is fine for the .in files. That will give a good flow for the help > > > > text. Most of the rest will be shorter anyways. > > > > > > > > But the makefiles have longer lines. The banner above the stage are already > > > > 78 chars wide and many of the variables at the top as well. > > > > And for the rest, readability really depends on the content and a defined > > > > textwidth suggests a hard limit that I don't want to set. > > > > > > > > Maybe a soft visual limit with cc=80 instead? > > > > > > [...] > > > > > > Maybe drop tw on both and use cc=80 on kconfig (as you suggested) > > > and cc=100 on makefiles? > > > > I don't think such a visual setting should be imposed on the user and > > could annoy some, myself included ;) > > > > Is this a problem in practice that has to be tackled at all? I do request more line-breaks when I review patches. It's not that often that I think we need urgent changes. But defining a good default in some way makes sense. > Indentation and file format are my primary reasons for adding modeline. > Make it much easier to work on when you switch between 5-10 formats > each day. So vim detect the file format for kconfig without any help. But I don't mind adding it explicitly. For 'noet ts=8 sw=8' we could also create a editorconfig file. That would work with more editors (with the appropriate plugins). > Personally I like to have automation tell me when lines need to be broken, > as it can generally give you a hit if you should refactor a code section for > smaller indentation so it's easier to read. Lets do tw=80 for the .in files and no width limit (for now) for the .make files. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |