From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 27 Jun 2025 11:18:17 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uV5Dt-00BZT4-0o for lore@lore.pengutronix.de; Fri, 27 Jun 2025 11:18:17 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uV5Dt-000123-13; Fri, 27 Jun 2025 11:18:17 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uV5Dq-00010Q-0e; Fri, 27 Jun 2025 11:18:14 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uV5Dp-005ahX-2g; Fri, 27 Jun 2025 11:18:13 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uV5Dp-00GXdQ-2X; Fri, 27 Jun 2025 11:18:13 +0200 Date: Fri, 27 Jun 2025 11:18:13 +0200 From: Michael Olbrich To: Ralf Glaser Message-ID: References: <20250613105036.19390-2-glaser@iotmaxx.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250613105036.19390-2-glaser@iotmaxx.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] chrony: correct config directory and create namespace X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Fri, Jun 13, 2025 at 12:50:37PM +0200, Ralf Glaser wrote: > --sysconfdir set to the location where the config files are installed. create chrony namespace /val/lib/chrony typo: s/val/var/ > > Signed-off-by: Ralf Glaser > --- > rules/chrony.make | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/rules/chrony.make b/rules/chrony.make > index 647b78272..64fc48ee5 100644 > --- a/rules/chrony.make > +++ b/rules/chrony.make > @@ -41,7 +41,7 @@ CHRONY_CONF_TOOL := autoconf > CHRONY_CONF_OPT := \ > --localstatedir=/var \ > --prefix=/usr \ > - --sysconfdir=/etc \ > + --sysconfdir=/etc/chrony \ So this is ugly. This was broken for some time when PTXCONF_CHRONY_INSTALL_CONFIG is installed, so we need to assume that projects install /etc/chrony.conf from another package (I know projects that do this). Changing sysconfdir will break those silently. So please make the change the other way around and move projectroot/etc/chrony/chrony.conf to projectroot/chrony/chrony.conf and the same for chrony.keys. You can also add something like this: @ptxd_get_alternative projectroot /etc/chrony/chrony.conf && \ ptxd_bailout "/etc/chrony/chrony.conf was moved to /etc/chrony.conf" \ "Please move $${ptxd_reply} accordingly." To catch old files. This does not work for the other case, because it must be in the package that installs the file. The same for chrony.keys. Michael > --disable-readline \ > --without-editline \ > $(call ptx/ifdef, PTXCONF_CHRONY_USE_NETTLE,,--disable-sechash) \ > @@ -130,6 +130,9 @@ ifdef PTXCONF_CHRONY_SYSTEMD_UNIT > /usr/lib/systemd/system/multi-user.target.wants/chronyd.service) > endif > > +#namespace > + @$(call install_copy, chrony, 0, 0, 0755, /var/lib/chrony) > + > @$(call install_finish, chrony) > > @$(call touch) > -- > 2.49.0 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |