From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 27 Jun 2025 12:41:41 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uV6Wb-00BaZl-30 for lore@lore.pengutronix.de; Fri, 27 Jun 2025 12:41:41 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uV6Wb-00028y-NX; Fri, 27 Jun 2025 12:41:41 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uV6WJ-00024t-E5; Fri, 27 Jun 2025 12:41:23 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uV6WJ-005bDi-0S; Fri, 27 Jun 2025 12:41:23 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uV6WJ-00HHp2-0H; Fri, 27 Jun 2025 12:41:23 +0200 Date: Fri, 27 Jun 2025 12:41:23 +0200 From: Michael Olbrich To: Christian Melki Message-ID: References: <20250616182108.1488050-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250616182108.1488050-1-christian.melki@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] libpng: Version bump. 1.6.48 -> 1.6.49 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Mon, Jun 16, 2025 at 08:21:08PM +0200, Christian Melki wrote: > https://sourceforge.net/p/libpng/code/ci/libpng16/tree/CHANGES > > * Add RISC-V vector option. > > * Re-add lost ARM NEON optimization. I removed this, misunderstanding > the work done. This can be enabled for ARM64 where NEON > is an unconditional addition. I think it also could be enabled > for ARM NEON capable hard-float and soft-fp (not soft-float). > > * Disable the automatic optimization. It seems to not get the ARM > NEON case right. What exactly did not work for you? So I looked at that stuff, and I think, the correct way to handle this is to _not_ specify --{en,dis}able-hardware-optimizations at all and then use --enable-arm-neon=$(call ptx/ifdef, PTXCONF_ARCH_ARM_NEON,api,no) Does that work in your case? Michael > Signed-off-by: Christian Melki > --- > rules/libpng.make | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/rules/libpng.make b/rules/libpng.make > index 07c6ea99b..824974289 100644 > --- a/rules/libpng.make > +++ b/rules/libpng.make > @@ -16,8 +16,8 @@ PACKAGES-$(PTXCONF_LIBPNG) += libpng > # > # Paths and names > # > -LIBPNG_VERSION := 1.6.48 > -LIBPNG_MD5 := 6ddbe2107e3811d51da698794b8fb4a2 > +LIBPNG_VERSION := 1.6.49 > +LIBPNG_MD5 := 66c58f211e8e9fc66e621965960df19c > LIBPNG := libpng-$(LIBPNG_VERSION) > LIBPNG_SUFFIX := tar.xz > LIBPNG_URL := $(call ptx/mirror, SF, libpng/$(LIBPNG).$(LIBPNG_SUFFIX)) > @@ -41,11 +41,14 @@ LIBPNG_CONF_OPT := \ > --enable-unversioned-links \ > --enable-unversioned-libpng-pc \ > --enable-unversioned-libpng-config \ > + --disable-hardware-optimizations \ > + --$(call ptx/endis, PTXCONF_ARCH_ARM64)-arm-neon \ > --disable-mips-msa \ > --disable-mips-mmi \ > --$(call ptx/endis, PTXCONF_ARCH_X86)-intel-sse \ > --disable-powerpc-vsx \ > --disable-loongarch-lsx \ > + --$(call ptx/endis, PTXCONF_ARCH_RISCV)-riscv-rvv \ > --with-binconfigs > > # ---------------------------------------------------------------------------- > -- > 2.34.1 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |