From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sun, 25 May 2025 15:38:25 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uJBYX-000C0U-0G for lore@lore.pengutronix.de; Sun, 25 May 2025 15:38:25 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1uJBYW-0005vy-PE; Sun, 25 May 2025 15:38:24 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1uJBYL-0005vo-UE; Sun, 25 May 2025 15:38:13 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uJBYL-0005lW-2A; Sun, 25 May 2025 15:38:13 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1uJBYL-003PMM-1z; Sun, 25 May 2025 15:38:13 +0200 Date: Sun, 25 May 2025 15:38:13 +0200 From: Michael Olbrich To: Thorsten Scherer Message-ID: References: <20250519115458.27687-1-t.scherer@eckelmann.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250519115458.27687-1-t.scherer@eckelmann.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] scripts/generate-report: Fix missing dot2tex import X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: g.schenk@eckelmann.de, ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Mon, May 19, 2025 at 01:54:58PM +0200, Thorsten Scherer wrote: > Removal of the global import broke license report generation. Fix it. > > File "/usr/local/stow/ptxdist-2025.03.0/lib/ptxdist-2025.03.0/scripts/report/latex.py", line 32, in format_dot > return (args[1]['name'], dot2tex(dot, docpreamble='\\usepackage[xetex]{hyperref}', figonly=True, > ^^^^^^^ > NameError: name 'dot2tex' is not defined Right, the local import is broken because it does not work with the multiprocessing pool. But it should still be a local import. I'll create the correct fix for that. Michael > Fixes: e27adde6e54d ("generate-report: remove global dot2tex import") > Signed-off-by: Thorsten Scherer > --- > scripts/report/latex.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/scripts/report/latex.py b/scripts/report/latex.py > index cdb564a41eab..71344f988d4f 100644 > --- a/scripts/report/latex.py > +++ b/scripts/report/latex.py > @@ -10,6 +10,7 @@ from multiprocessing import Pool > from os import path, environ > import hashlib > import subprocess > +from dot2tex import dot2tex > > from report.report import find_file, ReportException > from report.generator import Generator > -- > 2.47.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |