From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sat, 26 Apr 2025 12:16:29 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u8caD-005XAK-0K for lore@lore.pengutronix.de; Sat, 26 Apr 2025 12:16:29 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1u8caC-0004KN-SQ; Sat, 26 Apr 2025 12:16:28 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u8ca7-0004K7-Kp; Sat, 26 Apr 2025 12:16:23 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u8ca7-002BrF-1H; Sat, 26 Apr 2025 12:16:23 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1u8ca7-0083uA-17; Sat, 26 Apr 2025 12:16:23 +0200 Date: Sat, 26 Apr 2025 12:16:23 +0200 From: Michael Olbrich To: Christian Melki Message-ID: References: <20250422091459.1888069-1-l.goehrs@pengutronix.de> <84925692-ce9f-4c1b-94a1-08a371ebc32a@t2data.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <84925692-ce9f-4c1b-94a1-08a371ebc32a@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] rules: host-erofs-utils: package X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Leonard =?utf-8?B?R8O2aHJz?= , ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Tue, Apr 22, 2025 at 12:11:43PM +0200, Christian Melki wrote: > Hi Leonard, > > Minor license nag. > > On 4/22/25 11:14 AM, Leonard Göhrs wrote: > > [Du får inte e-post ofta från l.goehrs@pengutronix.de. Läs om varför det här är viktigt på https://aka.ms/LearnAboutSenderIdentification ] > > > > Erofs is a read only filesystem, much like squashfs, that is optimized > > for read performance (rather than e.g. maximum compression ratio). > > > > The erofs-utils host package allows building erofs images. > > Since genimage does not have erofs support yet (there is a pull request > > though [1]) this can for example be achieved via the tar input feature: > > > > $ mkfs.erofs -z zstd --ungzip --tar root.erofs root.tgz > > > > and a custom rule. > > > > [1]: https://github.com/pengutronix/genimage/pull/247 > > > > Signed-off-by: Leonard Göhrs > > --- > > patches/erofs-utils-1.8.5/autogen.sh | 1 + > > rules/host-erofs-utils.in | 19 +++++++++++++++ > > rules/host-erofs-utils.make | 36 ++++++++++++++++++++++++++++ > > 3 files changed, 56 insertions(+) > > create mode 120000 patches/erofs-utils-1.8.5/autogen.sh > > create mode 100644 rules/host-erofs-utils.in > > create mode 100644 rules/host-erofs-utils.make > > > > diff --git a/patches/erofs-utils-1.8.5/autogen.sh b/patches/erofs-utils-1.8.5/autogen.sh > > new file mode 120000 > > index 000000000..9f8a4cb7d > > --- /dev/null > > +++ b/patches/erofs-utils-1.8.5/autogen.sh > > @@ -0,0 +1 @@ > > +../autogen.sh > > \ No newline at end of file > > diff --git a/rules/host-erofs-utils.in b/rules/host-erofs-utils.in > > new file mode 100644 > > index 000000000..80dec1b80 > > --- /dev/null > > +++ b/rules/host-erofs-utils.in > > @@ -0,0 +1,19 @@ > > +## SECTION=hosttools_noprompt > > + > > +config HOST_EROFS_UTILS > > + tristate > > + default y if ALLYES > > + select HOST_LIBUUID > > + select HOST_ZLIB > > + select HOST_LZ4 if HOST_EROFS_UTILS_LZ4_SUPPORT > > + select HOST_ZSTD if HOST_EROFS_UTILS_ZSTD_SUPPORT > > + > > +if HOST_EROFS_UTILS > > + > > +config HOST_EROFS_UTILS_LZ4_SUPPORT > > + bool > > + > > +config HOST_EROFS_UTILS_ZSTD_SUPPORT > > + bool > > + > > +endif > > diff --git a/rules/host-erofs-utils.make b/rules/host-erofs-utils.make > > new file mode 100644 > > index 000000000..8f6165851 > > --- /dev/null > > +++ b/rules/host-erofs-utils.make > > @@ -0,0 +1,36 @@ > > +# -*-makefile-*- > > +# > > +# Copyright (C) 2025 by Leonard Göhrs > > +# > > +# For further information about the PTXdist project and license conditions > > +# see the README file. > > +# > > + > > +# > > +# We provide this package > > +# > > +HOST_PACKAGES-$(PTXCONF_HOST_EROFS_UTILS) += host-erofs-utils > > + > > +# > > +# Paths and names > > +# > > +HOST_EROFS_UTILS_VERSION := 1.8.5 > > +HOST_EROFS_UTILS_MD5 := a4a4d803bc5120ffacc05a453a505ff7 > > +HOST_EROFS_UTILS := erofs-utils-$(HOST_EROFS_UTILS_VERSION) > > +HOST_EROFS_UTILS_SUFFIX := tar.gz > > +HOST_EROFS_UTILS_URL := https://web.git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/snapshot/$(HOST_EROFS_UTILS).$(HOST_EROFS_UTILS_SUFFIX) > > +HOST_EROFS_UTILS_SOURCE := $(SRCDIR)/$(HOST_EROFS_UTILS).$(HOST_EROFS_UTILS_SUFFIX) > > +HOST_EROFS_UTILS_DIR := $(HOST_BUILDDIR)/$(HOST_EROFS_UTILS) > > +HOST_EROFS_UTILS_LICENSE := unknown > > I know this is host-side utils, but it doesn't look unknown to me? > Looks like the repo contains a specific LICENSES directory too. Indeed. Please fix the identifier and add the actual license files (in addition to 'COPYING'). Michael > > +HOST_EROFS_UTILS_LICENSE_FILES := file://COPYING;md5=73001d804ea1e3d84365f652242cca20 > > + > > +# ---------------------------------------------------------------------------- > > +# Prepare > > +# ---------------------------------------------------------------------------- > > + > > +# > > +# autoconf > > +# > > +HOST_EROFS_UTILS_CONF_TOOL := autoconf > > + > > +# vim: syntax=make > > -- > > 2.39.5 > > > > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |