From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Bruno Thomsen <bruno.thomsen@gmail.com>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 3/4] wavemon: add license files and correct spdx license identifier
Date: Sat, 26 Apr 2025 11:55:11 +0200 [thread overview]
Message-ID: <aAytfxw6e-VDb_RQ@pengutronix.de> (raw)
In-Reply-To: <20250414200705.38489-3-bruno.thomsen@gmail.com>
On Mon, Apr 14, 2025 at 10:07:03PM +0200, Bruno Thomsen wrote:
> Use GPL-3.0-only spdx license identifier.
>
> Signed-off-by: Bruno Thomsen <bruno.thomsen@gmail.com>
> ---
> rules/wavemon.make | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/rules/wavemon.make b/rules/wavemon.make
> index e56506767..ab6c77482 100644
> --- a/rules/wavemon.make
> +++ b/rules/wavemon.make
> @@ -14,14 +14,16 @@ PACKAGES-$(PTXCONF_WAVEMON) += wavemon
> #
> # Paths and names
> #
> -WAVEMON_VERSION := 0.7.5
> -WAVEMON_MD5 := 77d4a0f099ca98cf98a915adc70694ba
> -WAVEMON := wavemon-$(WAVEMON_VERSION)
> -WAVEMON_SUFFIX := tar.bz2
> -WAVEMON_URL := https://github.com/uoaerg/wavemon/releases/download/v$(WAVEMON_VERSION)/$(WAVEMON).$(WAVEMON_SUFFIX)
> -WAVEMON_SOURCE := $(SRCDIR)/$(WAVEMON).$(WAVEMON_SUFFIX)
> -WAVEMON_DIR := $(BUILDDIR)/$(WAVEMON)
> -WAVEMON_LICENSE := GPL
> +WAVEMON_VERSION := 0.7.5
> +WAVEMON_MD5 := 77d4a0f099ca98cf98a915adc70694ba
> +WAVEMON := wavemon-$(WAVEMON_VERSION)
> +WAVEMON_SUFFIX := tar.bz2
> +WAVEMON_URL := https://github.com/uoaerg/wavemon/releases/download/v$(WAVEMON_VERSION)/$(WAVEMON).$(WAVEMON_SUFFIX)
> +WAVEMON_SOURCE := $(SRCDIR)/$(WAVEMON).$(WAVEMON_SUFFIX)
> +WAVEMON_DIR := $(BUILDDIR)/$(WAVEMON)
> +WAVEMON_LICENSE := GPL-3.0-only
This is a bit of a mess:
- So the code header for this version says "... either version 2, or (at
your option) any later version".
- COPYING contains GPLv3.
- The help text says GPLv3.
- Upstream changed the code headers to GPLv3 or later.
So I think GPL-3.0-or-later makes the most sense here.
Michael
> +WAVEMON_LICENSE_FILES := \
> + file://COPYING;md5=d32239bcb673463ab874e80d47fae504
>
> # ----------------------------------------------------------------------------
> # Prepare
> --
> 2.49.0
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2025-04-26 9:55 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-14 20:07 [ptxdist] [PATCH 1/4] stm32flash: " Bruno Thomsen
2025-04-14 20:07 ` [ptxdist] [PATCH 2/4] serdisplib: " Bruno Thomsen
2025-04-26 9:41 ` Michael Olbrich
2025-04-14 20:07 ` [ptxdist] [PATCH 3/4] wavemon: " Bruno Thomsen
2025-04-26 9:55 ` Michael Olbrich [this message]
2025-04-14 20:07 ` [ptxdist] [PATCH 4/4] tomoyo-tools: " Bruno Thomsen
2025-04-26 9:43 ` [ptxdist] [PATCH 1/4] stm32flash: " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aAytfxw6e-VDb_RQ@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=bruno.thomsen@gmail.com \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox