From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sat, 26 Apr 2025 11:25:12 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u8bma-005WKS-2N for lore@lore.pengutronix.de; Sat, 26 Apr 2025 11:25:12 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1u8bma-0001FQ-H7; Sat, 26 Apr 2025 11:25:12 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u8bmO-0001FC-Fi; Sat, 26 Apr 2025 11:25:00 +0200 Received: from dude05.red.stw.pengutronix.de ([2a0a:edc0:0:1101:1d::54]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u8bmO-002BSm-0x; Sat, 26 Apr 2025 11:25:00 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1u8bmO-007qss-0m; Sat, 26 Apr 2025 11:25:00 +0200 Date: Sat, 26 Apr 2025 11:25:00 +0200 From: Michael Olbrich To: Leonard =?utf-8?B?R8O2aHJz?= Message-ID: References: <20250409114656.3602498-1-l.goehrs@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20250409114656.3602498-1-l.goehrs@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] util-linux: add support for enabling the findmnt command X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Wed, Apr 09, 2025 at 01:46:56PM +0200, Leonard Göhrs wrote: > Signed-off-by: Leonard Göhrs > --- > rules/util-linux.in | 6 ++++++ > rules/util-linux.make | 2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/rules/util-linux.in b/rules/util-linux.in > index 3effecd72..1118c7033 100644 > --- a/rules/util-linux.in > +++ b/rules/util-linux.in > @@ -94,6 +94,12 @@ config UTIL_LINUX_FDISK > comment "BusyBox' fdisk is selected!" > depends on BUSYBOX_FDISK > > +config UTIL_LINUX_FINDMNT > + bool > + prompt "findmnt" > + help > + findmnt - Find a mounted device from its mountpoint and vise versa > + > config UTIL_LINUX_FSCK > bool > prompt "fsck" > diff --git a/rules/util-linux.make b/rules/util-linux.make > index c1152257d..3f4213070 100644 > --- a/rules/util-linux.make > +++ b/rules/util-linux.make > @@ -78,7 +78,7 @@ UTIL_LINUX_CONF_OPT := \ > -Dbuild-fdformat=disabled \ > -Dbuild-fdisks=$(call ptx/endis, PTXCONF_UTIL_LINUX_FDISKS)d \ > -Dbuild-findfs=$(call ptx/endis, PTXCONF_UTIL_LINUX_FINDFS)d \ > - -Dbuild-findmnt=disabled \ > + -Dbuild-findmnt=$(call ptx/endis, PTXCONF_UTIL_LINUX_FINDMNT)d \ Building it but not installing it makes no sense. I would expect another hunk that adds findmnt to UTIL_LINUX_BIN-*. Michael > -Dbuild-flock=$(call ptx/endis, PTXCONF_UTIL_LINUX_FLOCK)d \ > -Dbuild-fsck=$(call ptx/endis, PTXCONF_UTIL_LINUX_FSCK)d \ > -Dbuild-fsfreeze=$(call ptx/endis, PTXCONF_UTIL_LINUX_FSFREEZE)d \ > -- > 2.39.5 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |