Re: [ptxdist] [PATCH] util-linux: add support for enabling the findmnt command

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Apr 09, 2025 at 01:46:56PM +0200, Leonard Göhrs wrote:
> Signed-off-by: Leonard Göhrs <l.goehrs@pengutronix.de>
> ---
>  rules/util-linux.in   | 6 ++++++
>  rules/util-linux.make | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/util-linux.in b/rules/util-linux.in
> index 3effecd72..1118c7033 100644
> --- a/rules/util-linux.in
> +++ b/rules/util-linux.in
> @@ -94,6 +94,12 @@ config UTIL_LINUX_FDISK
>  comment "BusyBox' fdisk is selected!"
>  	depends on BUSYBOX_FDISK
>  
> +config UTIL_LINUX_FINDMNT
> +	bool
> +	prompt "findmnt"
> +	help
> +	  findmnt - Find a mounted device from its mountpoint and vise versa
> +
>  config UTIL_LINUX_FSCK
>  	bool
>  	prompt "fsck"
> diff --git a/rules/util-linux.make b/rules/util-linux.make
> index c1152257d..3f4213070 100644
> --- a/rules/util-linux.make
> +++ b/rules/util-linux.make
> @@ -78,7 +78,7 @@ UTIL_LINUX_CONF_OPT	:= \
>  	-Dbuild-fdformat=disabled \
>  	-Dbuild-fdisks=$(call ptx/endis, PTXCONF_UTIL_LINUX_FDISKS)d \
>  	-Dbuild-findfs=$(call ptx/endis, PTXCONF_UTIL_LINUX_FINDFS)d \
> -	-Dbuild-findmnt=disabled \
> +	-Dbuild-findmnt=$(call ptx/endis, PTXCONF_UTIL_LINUX_FINDMNT)d \

Building it but not installing it makes no sense. I would expect another
hunk that adds findmnt to UTIL_LINUX_BIN-*.

Michael

>  	-Dbuild-flock=$(call ptx/endis, PTXCONF_UTIL_LINUX_FLOCK)d \
>  	-Dbuild-fsck=$(call ptx/endis, PTXCONF_UTIL_LINUX_FSCK)d \
>  	-Dbuild-fsfreeze=$(call ptx/endis, PTXCONF_UTIL_LINUX_FSFREEZE)d \
> -- 
> 2.39.5
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |