From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sun, 20 Apr 2025 21:00:11 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1u6Ztj-003IjL-12 for lore@lore.pengutronix.de; Sun, 20 Apr 2025 21:00:11 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1u6Ztj-0003II-3L; Sun, 20 Apr 2025 21:00:11 +0200 Received: from h4.cmg2.smtp.forpsi.com ([185.129.138.189]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1u6ZtT-0003I9-OE for ptxdist@pengutronix.de; Sun, 20 Apr 2025 20:59:56 +0200 Received: from lenoch ([91.218.190.200]) by cmgsmtp with ESMTPSA id 6ZtRubeKLMnq76ZtSuP14W; Sun, 20 Apr 2025 20:59:54 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triops.cz; s=f2019; t=1745175594; bh=1cxlYXgd1vT2HEjx9AvBeVsuXELRWtrzjHixL1qh2Ug=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=HRotLfmFSf0iXD9vOdb2+rCgCB0nPxuTp9/xhoqy/mC+s9biW/BXvbZwZTm7gn6NR jhIfzrVHUvtcKBf93qS+R4uaFXB0UUk4Wfzk2A4RNkL3SW5UZFbAyQcWkJyMzx0AEP I1Q31UFI5dnmHFH2o4dxmemAFomfaA59qWGd8UE/2om34OfHGub5DY9VdbU9wD9kAG EZyZFAFO4BegYnIdK36w3jeAlxuo85RqDG92GEy8s3uw4HGfqBydSoBSChWHVn5rHj 7JKxlKav9V1WPiiXv9JQ+PqiU9Jg1Z2yav2cobefFDevrBX0jd5q5EWxelKU3cqG7E XgEMNsWjp+wlg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triops.cz; s=f2019; t=1745175594; bh=1cxlYXgd1vT2HEjx9AvBeVsuXELRWtrzjHixL1qh2Ug=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=HRotLfmFSf0iXD9vOdb2+rCgCB0nPxuTp9/xhoqy/mC+s9biW/BXvbZwZTm7gn6NR jhIfzrVHUvtcKBf93qS+R4uaFXB0UUk4Wfzk2A4RNkL3SW5UZFbAyQcWkJyMzx0AEP I1Q31UFI5dnmHFH2o4dxmemAFomfaA59qWGd8UE/2om34OfHGub5DY9VdbU9wD9kAG EZyZFAFO4BegYnIdK36w3jeAlxuo85RqDG92GEy8s3uw4HGfqBydSoBSChWHVn5rHj 7JKxlKav9V1WPiiXv9JQ+PqiU9Jg1Z2yav2cobefFDevrBX0jd5q5EWxelKU3cqG7E XgEMNsWjp+wlg== Date: Sun, 20 Apr 2025 20:59:53 +0200 From: Ladislav Michl To: Bruno Thomsen Message-ID: References: <20250418113357.23654-1-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-CMAE-Envelope: MS4xfFfZ0ZlfBssaTNZQNGcRHlNyZZMeZaBUF2mDOBI1XBGuNGY+X0yPxuGBafDkPCG7o2h9lYMw1+aSvjrE/sCB6Yi1aP0D5qfsLCCUpwvfUhs0j23qJBW8 xySdHmo2TcNcCBakHEb+q9yDri+mG7qMYr6rdGUHUs3dI5oPnrzXrmmHW7WhvGL5oHanW4ZG0VOTr/4nHCEJc2S5aFLQ6JLlIfNEEduo2jwJ7lEKlDVe++lt X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED, SPF_HELO_PASS,SPF_NONE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [RFC PATCH] ptxdist: add repology sub command X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Sun, Apr 20, 2025 at 06:18:32PM +0200, Bruno Thomsen wrote: > Hi > > I also started with ptxdist-lint but might have removed a little too > much of the makefile > and relied too much on the bash script part :) > It would be nice if we could run more makefile to get dynamic versions > and licenses resolved > before handoff to bash script. Or maybe we should do it more like spdx > sbom in Python. > > The sorting and indentation is currently done externally by jq, but > that could be moved inside > ptxd_make_world_repology script function. > > Also I am a bit unsure if this cross rule variable access is actually > more of a bug then a feature. > > $ rg XORG_LIB_X11_LICENSE > rules/libx11-locale.make > 24:LIBX11_LOCALE_LICENSE = $(XORG_LIB_X11_LICENSE) > > rules/xorg-lib-X11.make > 24:XORG_LIB_X11_LICENSE := MIT I guess we are overcomplicating it. What about simply (working concept): $ cat scripts/lib/ptxd_make_world_repology.sh PTX_PACKAGES_TARGET := \ $(sort $(filter-out host-system-%,$(filter-out host-%,$(filter-out image-%,$(PTX_PACKAGES_ALL))))) PHONY += ptxdist-repology ptx/repology = \ @$(foreach pkg,$(PTX_PACKAGES_TARGET), \ echo "{\"name\": \"${pkg}\", \"version\": \"$($(PTX_MAP_TO_PACKAGE_$(pkg))_VERSION)\", \"license\": \"$($(PTX_MAP_TO_PACKAGE_$(pkg))_LICENSE)\"}"$(ptx/nl)) ptxdist-repology: @$(call targetinfo) @$(call ptx/repology) # vim: syntax=make EOF Doing all inside makefile quite simplifies it and performance is probably not critical here. > Ladislav you can find latest development version of this repology support here: > https://github.com/baxeno/ptxdist/tree/repology_support > (you can send PR directly if you wish) I'll try to cook up something but not sooner than next week. l.