From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 21 Jan 2022 09:46:10 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nApYg-008bTC-Ge for lore@lore.pengutronix.de; Fri, 21 Jan 2022 09:46:10 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nApYf-0008LE-TK; Fri, 21 Jan 2022 09:46:09 +0100 Received: from mail-db8eur05on2044.outbound.protection.outlook.com ([40.107.20.44] helo=EUR05-DB8-obe.outbound.protection.outlook.com) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nApYa-0008Kn-17 for ptxdist@pengutronix.de; Fri, 21 Jan 2022 09:46:04 +0100 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=igWPwa4SizxTov2yGKjffv4HSzAxI2RFnDwclQp2lnSiB0VzLDZ66gX7SuNJxEGEByRXurSXx8Sa005RvX7vEFOYq4n4IUXV1ZhNQzdnUiP1wKLEGIZtbdXBCyZSgKbfThMBHcBejxQsDCegFeALMAZdfKZ9FuUOGMbrN0vnj/4E1ff/RkT00XWlnblQuQD6RoQ4XmtWpR1DK8KK1DCaI+XGH6a9Nv5byjkw5jQo7LZhdOCcVHEIErmaZDDpbwbio/ZBcHe/Kcbap/kO87d2GhEfzjF069W6MXTii2m9Owp4CRjYVaZ9vDUrRYaNYhXObSdzgbekhHUTyGk1qrKX7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CyMMacYt8Cs+cfvp9+0daxncjheudw7eS3o2R83a9Fs=; b=iQE+G+SGc6L5XbApZH1WkWJJxdEG5xQy9E9AbC9lYW8AXs06cn379/CsTQ0OvYmBsVvdBRvP45oQ3aIqiXCOx/u9QgM4un2EG1nRYIdIooVM2Cwo4EvCInHrIpzyWxL+ZUS0/+1bSiXJuC0vPerTVBtwdlXXANmXJxfLE6WQtA9ul8uRxumcBw6vdOcbEd06CmqKeKAu+RTROLS7CPm0cyb5o2U8/15VkyVLUObFmccGrC20pU2f0upROSC0pPMKkCOoBgD0nIxgxFrTa2DZ/aHo90E2XZQYshv855cQ4mZf56WI+WT6B46TP4tvcWPEM9kE723jvSJDi6BUvOkFnw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=t2datacom.onmicrosoft.com; s=selector1-t2datacom-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CyMMacYt8Cs+cfvp9+0daxncjheudw7eS3o2R83a9Fs=; b=Nm/by4wQb0Cbp6jr9Z5b+1Fb76GK8OM2cYZC1UyHNTGoJb2ncPecKjUACXggi5mta24FevRWZAcK968OIjESwjOTJzB03MD6oQMbDJTeKPAXUY2O2C8qn7gKFIfmEA8RIx8qYthSDeNhFiXRc/ooiFvriqCTB1MagvEwH+yApN0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=t2data.com; Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) by AM9P251MB0070.EURP251.PROD.OUTLOOK.COM (2603:10a6:20b:41b::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4909.8; Fri, 21 Jan 2022 08:46:02 +0000 Received: from DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::10ab:30da:9dfb:56fe]) by DB9P251MB0618.EURP251.PROD.OUTLOOK.COM ([fe80::10ab:30da:9dfb:56fe%3]) with mapi id 15.20.4888.013; Fri, 21 Jan 2022 08:46:02 +0000 Message-ID: Date: Fri, 21 Jan 2022 09:44:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Content-Language: en-US To: ptxdist@pengutronix.de References: <20220114115647.2049883-1-christian.melki@t2data.com> From: Christian Melki In-Reply-To: X-ClientProxiedBy: GV3P280CA0066.SWEP280.PROD.OUTLOOK.COM (2603:10a6:150:a::9) To DB9P251MB0618.EURP251.PROD.OUTLOOK.COM (2603:10a6:10:334::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9428a84b-047b-4f0c-8466-08d9dcba740c X-MS-TrafficTypeDiagnostic: AM9P251MB0070:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: H6tw4XnyMzwCyc+ADOgoSpsvlI6VlQ7P80tTBARUPEL8Psfn5H4Xdom+ScXztwv18i8havEqHTYvhaf6QMyGGwfsXVSk2ANc0OHnszgqbHTQcXOQl76mEpxuV3MzfnolEEApxIVZq5PMyFZYQ8FcM99vKVHMiZ4tr9+rFbD2Vd3g52/t9W4suN4DOA2H8oLko53S5PNvugcARUM9SIgPej+06GcRZq/HaVcd94Amjch7GQibY5cxLXliVbImoe690W6h2sVpbPkpeyoVwuowmi9FzZzr9TDcVJ9PXp9WGYvzHPnFgjUUjIOAXhrLjrQ/R2WCDoNYk/UvNFdi51uDBx54ADsGDB5ohQf1Wj272ushG7WiK8z7fTGkj4IGKyOtAAUxrmWr04wZf4uioa+rxarxNeLF7DC/Er5EM3cNzUaSFk0gd1i2kfw7maoPIq138vgNLkSpFntP60sWuCgGtdKTBkMRvTvebAFFsMYWrRnRVlcoP7Jox/3MSjyWX/3cqFZ/5MWt7ikf5VFz00aidihbqJWb/9wRE+2oQZQeQXOR+tyEtE2KaWqMRfd/P8HuLIm/FFzTDAk/XZpLCNIB42+svH1UsAeVJ4mAvfnLuNtcYj2xInhcedFQizLalWjAeydkhmkDxAkhUzxJmCCllEa94/WKggal7cJ2Hw4Dz4R8siqjXNfuHARj25eTq4OhoqlmOrjwMLwvF58nYzFF8wMsXFZ7jN6DZVwx/veB6iYv8XNbE1wNsIi0ly3xCeZGJ/2nSUjKUpZr29UP+FCdNw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB9P251MB0618.EURP251.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(366004)(346002)(39830400003)(376002)(396003)(136003)(8936002)(66946007)(52116002)(2616005)(5660300002)(66556008)(66476007)(6486002)(26005)(8676002)(6506007)(508600001)(6916009)(6512007)(53546011)(83380400001)(31696002)(86362001)(316002)(36756003)(6666004)(186003)(44832011)(2906002)(38350700002)(38100700002)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?R0lHRWc3SUJWNjRheU4yWjNTZ01DM1RYbkMrZmlZRUkxaE8zZTB4WkhHZnl5?= =?utf-8?B?OHEycEIwMVVTV29lNXN5Q3JXdEtkcG05RzZKT1NCaFhlWS9rWWhPMldvV1hl?= =?utf-8?B?OEFhN2Q3UExmL0lGL0V4ZklsTHk0Y0hTQjlJd2Jad0FwVHZxdUh2TGM5Mmt1?= =?utf-8?B?UlliVHBtTnlyNjFVMjZCY0ZDYXJuYnhybHBhM25ranFWNHhyNUhDYU5HeXha?= =?utf-8?B?WTN6UEFwcWtTNGFhZEFyeGNWQkIrMHE3bWZqQUpZNzVqcmV5Ymx1NUV3U1Nw?= =?utf-8?B?Yk1VQWxRWS92bUdsVWVTbFE2RVU1RnhxVTBDK1pBUGM4REhZTC9uaHdkQ3RL?= =?utf-8?B?c2h1QXRBR21DTWxIdHRnNjRCaWlQT1FEOXZjTWM0U1dqTk9hM01qYzhiZlF5?= =?utf-8?B?UUtnUHR2NSs1NjgrWk9iVkZOMzM4KzJiVk5MUEx1OFFKR25hRGFkUlQydmZD?= =?utf-8?B?T09QOUd6QUR0QTJ2bjRyNHE1WnhxR3pGS1pwV1VuY3dNTGJ3RW1obU5LV09G?= =?utf-8?B?dDZjM3N4MlFTbGI2eHhmUityYTdQc3pHWm1CMjU4bGNKSUtodzc0S1ZjNnB2?= =?utf-8?B?bkp3K0tNTGcrWGd0NHBLeTVqQmpuenpadDVRU1JuWldEV2p5Mm5LV05ORGVH?= =?utf-8?B?eHdqb0VEeDBVM2dvR0ZzS0pKRXRKOHlRSU5XbkFaMTBOelc2a0p5UHd2U2Jo?= =?utf-8?B?YlVERHJ6RzNWT0lyU1RZQjFEckVtUnp3MldkUWRhblFmdHNEeDFoR1VBcVRR?= =?utf-8?B?VDhtRFp3WHJVRUJRU05QdWRtQTVYbzRtTWJQYUlIRFhpemloMkJhNnZDR2Ev?= =?utf-8?B?ekNvRkNJY2wzSU95WXh2MkpaY2d5NVpCNU9JRktYczJlMDljcUcxVnp3WXVD?= =?utf-8?B?YkhvK2RJbU5Xb0R4SDA1amQrRFV6UjRjaVFwT0xBekwzOGhlSlA4cnRvcTVV?= =?utf-8?B?S0lBbm1HR0ROTTZ6eUFlR0prUm1TZGUxdjlvK0dzamxFSFEzRm9WTlBvbi9q?= =?utf-8?B?QWxlSHZNUXErZzNUSFV1RkRDc1B4RjVUQXJ3RUR5SnRxY1E2MER2WnZjY2V6?= =?utf-8?B?clJjSE9zYjg2cFl4anAxaGFkOUhVYklKSjcvWkdYREQwZkFFRG9hcjVKRHJU?= =?utf-8?B?VXNacis3ZW1HZlo3YlovNHpvbXpUclFLdndsT0prVEExVjgyb3d4dk95ZGJI?= =?utf-8?B?MHQzQTJBclNpT3ZaS1lpdTJVRXFnSVRmVnExeDAvS0lRSVZnUGZveUhEY1lU?= =?utf-8?B?L0JTZjRQMkVRd09VUktyMFplbVNRTW1ncTg4Tk1sN2ZqK2R0c1VLdEpSRG1M?= =?utf-8?B?dWt1d1NwYWtxT1Y4cFpQWUNFQ1UwWU9oRHI5Nmh5UTZNazloNGlmOG00QzB0?= =?utf-8?B?NWpncFR1Y0dkd3hDYnBTVW82QWY0akRrRkEycDF1RVlhUFhCNTR0eVNzMHVO?= =?utf-8?B?dXVzQTM3ZCtvWnJnaTZDcFU1VDlLMjR6NjdFaFZxSGUvU3ZzcXFXaG1mc0Yv?= =?utf-8?B?TExqYjM5enRXb2lGeVZQa3hGd0VFY3hwQ3V5OEhyMkx6NE90c3hxdkRCZDcy?= =?utf-8?B?WjA4TXVxc1lJWGtzcXM5VUEyZDhUbzJ3dEVidytJR2VkR2R5WWlpaFV2UWlG?= =?utf-8?B?MGdnYlUreWdVL1V0aHJTN0UzTThVWk5yZTMxa2ovV1FwcVM5c1FOZGw1TUxN?= =?utf-8?B?ZlZNa1ptY2ZHVW1lVHhCWVV2SXQwTmNLaUJBZHk0QXlyanNyeFAybUQ2VG9D?= =?utf-8?B?cU45Wm5RejFkYjhYVkg5UTBEa3JaMWR5bEFqUDg0dzhKUVgwWkJjL0EvZDBG?= =?utf-8?B?UEZzQi85SnFrbWVHRjV0VTVYU0xROFpiMnBNcERtT25rSHhQcDJlNW5FSTh3?= =?utf-8?B?QTFOeFBsWXlPTnNNYzgxUDBsdlNyeGdkWmoycW1rTXJNdnRPQlBiTXRaejhx?= =?utf-8?B?a2VwQSt4bzBCdTFWMVViSlFOTGNpWkFTR1g1V1NjNzVrNDc4V2IvZlNqUWZy?= =?utf-8?B?b3BJNDZ2REFlOXRYNG9EeWlleUw1UXBxSVNIQzhTN2FLM2czeTU1cnh3MGpt?= =?utf-8?B?bVlmRnA0TUZOUERRSXM4V1hUNlVVK010V1NOTXpOZTFKRGZweVNyOXl4eWNG?= =?utf-8?B?SElTMTF2L1VlWlFHZm1oSzY5c3lvbUpiaFlNb3pNb09KQUUwT0hlcFkrejFt?= =?utf-8?B?WmQ3dTZpTE1rSUNLQVJralRqZDF3WngwTTMyVEVIUW9lTVJCbnczUkd5cUlQ?= =?utf-8?Q?xfARsaOiiiV8pSY5ci0QOTjTDlenJjP6ayLKFg4AOk=3D?= X-OriginatorOrg: t2data.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9428a84b-047b-4f0c-8466-08d9dcba740c X-MS-Exchange-CrossTenant-AuthSource: DB9P251MB0618.EURP251.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Jan 2022 08:46:01.9748 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 27928da5-aacd-4ba1-9566-c748a6863e6c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: asFmWS6M7+2hp942ZNkGRHri3jhNTfKBmVGm7ZYE6GHOWK+w5++Beqvsh3lysRI4K56Fj/31LuNFrK7lbwUNNT3LSxztgH/E24IYkDhLHPU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM9P251MB0070 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.ext.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-1.9 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [PATCH] image-hdimg.make: Add PROJECT and PROJECT_VERSION variables. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 1/21/22 9:19 AM, Michael Olbrich wrote: > On Fri, Jan 14, 2022 at 12:56:47PM +0100, Christian Melki wrote: >> Ideally, I'd like this to be in the generic genimage env. >> I need this to be able to name images according to the project. > > I don't really like adding random stuff here. And it's easy to expand this > locally: > > IMAGE_HDIMG_ENV += \ > PROJECT=$(PTXCONF_PROJECT) \ > PROJECT_VERSION=$(PTXCONF_PROJECT_VERSION) > > In rules/image-hdimg..make in your BSP since ptxdist-2021.12.0 or in > rules/post/.make before that. > So you don't need to overwrite the upstream rule entirely and it's easy to > maintain. > > Michael > Mmm. I do agree that this is pretty random, but it's not random wanting to name your images according to some project/project-version naming scheme. I was thinking more like adding project and project_version to the calling image env. But I was unsure how to do that. Maybe this was totally unnecessary because the variables already existed in the image env in some form? >> Signed-off-by: Christian Melki >> --- >> rules/image-hdimg.make | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/rules/image-hdimg.make b/rules/image-hdimg.make >> index b470c0fb6..6f0012a85 100644 >> --- a/rules/image-hdimg.make >> +++ b/rules/image-hdimg.make >> @@ -57,6 +57,8 @@ IMAGE_HDIMG_ENV = \ >> PARTITION_TABLE_TYPE=$(call ptx/ifdef, PTXCONF_IMAGE_HDIMG_GPT,gpt,mbr) \ >> PARTITION_TYPE_SUFFIX=$(call ptx/ifdef, PTXCONF_IMAGE_HDIMG_GPT,-uuid) \ >> ROOT_PARTITION_TYPE=$(call ptx/ifdef, PTXCONF_IMAGE_HDIMG_GPT,L,0x83) \ >> + PROJECT=$(PTXCONF_PROJECT) \ >> + PROJECT_VERSION=$(PTXCONF_PROJECT_VERSION) \ >> $(IMAGE_HDIMG_BOOTLOADER_ENV) >> >> $(IMAGE_HDIMG_IMAGE): >> -- >> 2.30.2 >> >> >> _______________________________________________ >> ptxdist mailing list >> ptxdist@pengutronix.de >> To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de >> > _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de