Re: [ptxdist] [PATCH v2] weston: build color management module

[Christian Melki <christian.melki@t2data.com>]

Hello Benjamin,

On 9/3/24 3:14 PM, Benjamin Gaignard wrote:
> [Du får inte e-post ofta från benjamin.gaignard@collabora.com. Läs om varför det här är viktigt på https://aka.ms/LearnAboutSenderIdentification ]
> 
> Add an option to build weston color management module.
> 
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@collabora.com>
> ---
>   rules/weston.in   | 1 +
>   rules/weston.make | 2 +-
>   2 files changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/rules/weston.in b/rules/weston.in
> index 10f0e9172..bc742d2fc 100644
> --- a/rules/weston.in
> +++ b/rules/weston.in
> @@ -40,6 +40,7 @@ menuconfig WESTON
>          select PIPEWIRE                 if WESTON_BACKEND_PIPEWIRE
>          select NEATVNC                  if WESTON_BACKEND_VNC
>          select PAM                      if WESTON_BACKEND_VNC
> +       select LCMS                     if WESTON_COLOR_MANAGEMENT_LCMS

Right. But you also need to make the option selectable.
You can look at the other WESTON_ marked options in the .in file.

Christian

>          prompt "weston                        "
>          help
>            Wayland compositor reference implementation
> diff --git a/rules/weston.make b/rules/weston.make
> index 35ddab180..b44b661a7 100644
> --- a/rules/weston.make
> +++ b/rules/weston.make
> @@ -45,7 +45,7 @@ WESTON_CONF_OPT               := \
>          -Dbackend-vnc=$(call ptx/truefalse,PTXCONF_WESTON_BACKEND_VNC) \
>          -Dbackend-wayland=$(call ptx/truefalse,PTXCONF_WESTON_GL) \
>          -Dbackend-x11=false \
> -       -Dcolor-management-lcms=false \
> +       -Dcolor-management-lcms=$(call ptx/truefalse,PTXCONF_WESTON_COLOR_MANAGEMENT_LCMS) \
>          -Ddemo-clients=$(call ptx/truefalse,PTXCONF_WESTON_IVISHELL_EXAMPLE) \
>          -Ddeprecated-color-management-colord=false \
>          -Ddeprecated-color-management-static=false \
> --
> 2.43.0
> 
>