Re: [ptxdist] [PATCH] add initial version of host-openocd package

[Roland Hieber <rohieb@rohieb.name>]

Hi,

On 17.01.2017 14:22, fixed-term.Oleksij.Rempel@de.bosch.com wrote:
> From: Oleksij Rempel <linux@rempel-privat.de>
> 
> openocd 0.10.0-rc2
> 
> Signed-off-by: Oleksij Rempel <linux@rempel-privat.de>
> ---
>  rules/host-openocd.in   |  8 ++++++++
>  rules/host-openocd.make | 37 +++++++++++++++++++++++++++++++++++++
>  2 files changed, 45 insertions(+)
>  create mode 100644 rules/host-openocd.in
>  create mode 100644 rules/host-openocd.make
> 
> diff --git a/rules/host-openocd.in b/rules/host-openocd.in
> new file mode 100644
> index 0000000..64e50b2
> --- /dev/null
> +++ b/rules/host-openocd.in
> @@ -0,0 +1,8 @@
> +## SECTION=hosttools
> +
> +menuconfig HOST_OPENOCD
> +	tristate
> +	default ALLYES
> +	prompt "host-side openocd             "
> +	select HOST_GLIB
> +	select HOST_LIBUSB
> diff --git a/rules/host-openocd.make b/rules/host-openocd.make
> new file mode 100644
> index 0000000..ba894ed
> --- /dev/null
> +++ b/rules/host-openocd.make
> @@ -0,0 +1,37 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2016 by Oleksij Rempel <linux@rempel-privat.de>
> +#
> +# See CREDITS for details about who has contributed to this project.
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +HOST_PACKAGES-$(PTXCONF_HOST_OPENOCD) += host-openocd
> +
> +#
> +# Paths and names
> +#
> +HOST_OPENOCD_VERSION	:= 0.10.0-rc2
> +HOST_OPENOCD_MD5	:= b5ac2a635e89186779c51a9cbdc01161
> +HOST_OPENOCD		:= openocd-$(HOST_OPENOCD_VERSION)
> +HOST_OPENOCD_SUFFIX	:= tar.bz2
> +HOST_OPENOCD_URL	:= https://downloads.sourceforge.net/project/openocd/openocd/$(HOST_OPENOCD_VERSION)/$(HOST_OPENOCD).$(HOST_OPENOCD_SUFFIX)
> +HOST_OPENOCD_SOURCE	:= $(SRCDIR)/$(HOST_OPENOCD).$(HOST_OPENOCD_SUFFIX)
> +HOST_OPENOCD_DIR	:= $(HOST_BUILDDIR)/$(HOST_OPENOCD)
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +
> +HOST_OPENOCD_CONF_TOOL	:= autoconf

Well, that was short and easy :) But I see various enable/disable flags
in the configure help that default to "auto" and are not handled here in
the Makefile. These flags should be included for the build to be
reproducible, or have you checked that they don't depend on the build
order of the system? In any case, it is probably a good idea to include
any configure options in the menu to let the user choose the feature set
(i.e., memory footprint, and additional dependencies, if any).

 - Roland

> +
> +# vim: syntax=make
> 


_______________________________________________
ptxdist mailing list
ptxdist@pengutronix.de