From: Michael Tretter <m.tretter@pengutronix.de>
To: Michael Grzeschik <mgr@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] libusbgx: update to release 0.3.0
Date: Tue, 1 Oct 2024 12:24:26 +0200 [thread overview]
Message-ID: <ZvvN2vHAoyJYU8iP@pengutronix.de> (raw)
In-Reply-To: <ZvvK3leneXUX5Qt-@pengutronix.de>
On Tue, 01 Oct 2024 12:11:42 +0200, Michael Grzeschik wrote:
> On Tue, Oct 01, 2024 at 09:23:34AM +0200, Michael Tretter wrote:
> > On Fri, 27 Sep 2024 16:28:45 +0200, Michael Grzeschik wrote:
> > > Since libusbgx was released to version 0.3.0 we update the rule.
> > >
> > > This release also includes the support to build with meson so we also
> > > change the build system in the rule file.
> > >
> > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> > > ---
> > > ...1-Fix-39-Compilation-fails-on-gcc-v8.patch | 20 -
> > > ...ld-with-glibc-2.28-since-sys-sysmacr.patch | 90 ---
> > > ...vid-pid-remove-add-dynamic-vid-pid-s.patch | 67 --
> > > .../0004-libusbgx-Add-UVC-support.patch | 737 ------------------
> > > patches/libusbgx-0.2.0/autogen.sh | 16 -
> > > patches/libusbgx-0.2.0/series | 7 -
> > > rules/libusbgx.in | 1 +
> > > rules/libusbgx.make | 26 +-
> > > 8 files changed, 13 insertions(+), 951 deletions(-)
> > > delete mode 100644 patches/libusbgx-0.2.0/0001-Fix-39-Compilation-fails-on-gcc-v8.patch
> > > delete mode 100644 patches/libusbgx-0.2.0/0002-libusbgx-fix-build-with-glibc-2.28-since-sys-sysmacr.patch
> > > delete mode 100644 patches/libusbgx-0.2.0/0003-examples-gadget-vid-pid-remove-add-dynamic-vid-pid-s.patch
> > > delete mode 100644 patches/libusbgx-0.2.0/0004-libusbgx-Add-UVC-support.patch
> > > delete mode 100755 patches/libusbgx-0.2.0/autogen.sh
> > > delete mode 100644 patches/libusbgx-0.2.0/series
> > >
> > [...]
> > > diff --git a/rules/libusbgx.in b/rules/libusbgx.in
> > > index e576f842e..95e92a04c 100644
> > > --- a/rules/libusbgx.in
> > > +++ b/rules/libusbgx.in
> > > @@ -2,6 +2,7 @@
> > >
> > > menuconfig LIBUSBGX
> > > bool
> > > + select HOST_MESON
> > > select LIBCONFIG if LIBUSBGX_SCHEMES
> > > prompt "libusbgx "
> > > help
> > > diff --git a/rules/libusbgx.make b/rules/libusbgx.make
> > > index f6ccb6e9b..3de7f19f6 100644
> > > --- a/rules/libusbgx.make
> > > +++ b/rules/libusbgx.make
> > > @@ -14,11 +14,11 @@ PACKAGES-$(PTXCONF_LIBUSBGX) += libusbgx
> > > #
> > > # Paths and names
> > > #
> > > -LIBUSBGX_VERSION := 0.2.0
> > > -LIBUSBGX_MD5 := a8ea2234c6355ac8ad2ca86c453297bd
> > > -LIBUSBGX := libusbgx-$(LIBUSBGX_VERSION)
> > > -LIBUSBGX_SUFFIX := zip
> > > -LIBUSBGX_URL := https://github.com/libusbgx/libusbgx/archive/refs/tags/libusbgx-v$(LIBUSBGX_VERSION).zip
> > > +LIBUSBGX_VERSION := 0.3.0
> > > +LIBUSBGX_MD5 := f2ca9c639e6fc6ee9dbecb545fa61637
> > > +LIBUSBGX := libusbgx-v$(LIBUSBGX_VERSION)
> >
> > Is the additional v intentional?
>
> Yes, I wanted to be consistent with the source package which is located
> at ..refs/tags/libusbgx-v$(LIBUSGX_VERSION).
> ^
>
> I will update the comment in the description to docuemnt this.
Other PTXdist packages seem to explicitly avoid the "v" in the version
and the source and build directories. Thus, trying to keep the
directories and the tag name consistent seems to be an outlier to me.
I'd prefer dropping the v to be consistent with other packages.
Michael
>
> mgr
>
> > > +LIBUSBGX_SUFFIX := tar.gz
> > > +LIBUSBGX_URL := https://github.com/linux-usb-gadgets/libusbgx/archive/refs/tags/libusbgx-v$(LIBUSBGX_VERSION).$(LIBUSBGX_SUFFIX)
> > > LIBUSBGX_SOURCE := $(SRCDIR)/$(LIBUSBGX).$(LIBUSBGX_SUFFIX)
> > > LIBUSBGX_DIR := $(BUILDDIR)/$(LIBUSBGX)
> > > LIBUSBGX_LICENSE := GPL-2.0-or-later AND LGPL-2.1-or-later
> > > @@ -32,18 +32,16 @@ LIBUSBGX_LICENSE_FILES := \
> > > # Prepare
> > > # ----------------------------------------------------------------------------
> > >
> > > -LIBUSBGX_CONF_ENV := $(CROSS_ENV)
> > > -
> > > #
> > > -# autoconf
> > > +# meson
> > > #
> > > -LIBUSBGX_CONF_TOOL := autoconf
> > > +LIBUSBGX_CONF_TOOL := meson
> > > LIBUSBGX_CONF_OPT := \
> > > - $(CROSS_AUTOCONF_USR) \
> > > - --$(call ptx/wwo, PTXCONF_LIBUSBGX_SCHEMES)-libconfig \
> > > - --enable-examples \
> > > - --$(call ptx/endis, PTXCONF_LIBUSBGX_SCHEMES)-gadget-schemes \
> > > - --disable-doxygen-doc
> > > + $(CROSS_MESON_USR) \
> > > + -Dexamples=true \
> > > + -Dtests=disabled \
> > > + -Dgadget-schemes=$(call ptx/endis, PTXCONF_LIBUSBGX_SCHEMES)d \
> > > + -Ddoxygen=disabled
> > >
> > > # ----------------------------------------------------------------------------
> > > # Target-Install
> > > --
> > > 2.39.5
> > >
> > >
> > >
> >
next prev parent reply other threads:[~2024-10-01 10:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-27 14:28 Michael Grzeschik
2024-10-01 7:23 ` Michael Tretter
2024-10-01 10:11 ` Michael Grzeschik
2024-10-01 10:24 ` Michael Tretter [this message]
2024-10-11 10:24 ` [ptxdist] [APPLIED] " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvvN2vHAoyJYU8iP@pengutronix.de \
--to=m.tretter@pengutronix.de \
--cc=mgr@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox