From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 18 Sep 2024 16:52:56 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sqw37-005kDE-0p for lore@lore.pengutronix.de; Wed, 18 Sep 2024 16:52:56 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sqw36-0005XV-5u; Wed, 18 Sep 2024 16:52:56 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sqw2k-0005W6-Kl; Wed, 18 Sep 2024 16:52:34 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sqw2k-008q0X-8D; Wed, 18 Sep 2024 16:52:34 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sqw2k-00FVfF-0g; Wed, 18 Sep 2024 16:52:34 +0200 Date: Wed, 18 Sep 2024 16:52:34 +0200 From: Michael Olbrich To: Roland Hieber Message-ID: References: <20240826124929.2674425-1-rhi@pengutronix.de> <20240918104846.3z6ifi3wu3mafm4j@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240918104846.3z6ifi3wu3mafm4j@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] open62541: fix inclusion of mdnsd license in license report X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Wed, Sep 18, 2024 at 12:48:46PM +0200, Roland Hieber wrote: > On Fri, Sep 13, 2024 at 09:06:00AM +0200, Michael Olbrich wrote: > > On Mon, Aug 26, 2024 at 02:49:29PM +0200, Roland Hieber wrote: > > > Signed-off-by: Roland Hieber > > > --- > > > rules/open62541.make | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/rules/open62541.make b/rules/open62541.make > > > index 1da04c7f9e69..a44bc189a816 100644 > > > --- a/rules/open62541.make > > > +++ b/rules/open62541.make > > > @@ -34,8 +34,8 @@ OPEN62541_MDNSD_SUFFIX := tar.gz > > > OPEN62541_MDNSD_URL := https://github.com/Pro/mdnsd/archive/$(OPEN62541_MDNSD_VERSION).$(OPEN62541_MDNSD_SUFFIX) > > > OPEN62541_MDNSD_SOURCE := $(SRCDIR)/$(OPEN62541_MDNSD).$(OPEN62541_MDNSD_SUFFIX) > > > OPEN62541_MDNSD_DIR := $(OPEN62541_DIR)/deps/mdnsd > > > -OPEN62541_MDNSD_LICENSE := BSD-3-Clause > > > -OPEN62541_MDNSD_LICENSE_FILES := file://LICENSE;md5=3bb4047dc4095cd7336de3e2a9be94f0 > > > +OPEN62541_LICENSE += AND BSD-3-Clause > > > +OPEN62541_LICENSE_FILES += file://deps/mdnsd/LICENSE;md5=3bb4047dc4095cd7336de3e2a9be94f0 > > > > License check fails because this file does not exist. > > It only fails for me in host-open62541.report. I assume that > OPEN62541_PARTS += OPEN62541_MDNSD is not applied to the host package, > because platform-v7a/build-host/open62541-1.3.4/deps/mdnsd/ is empty. Right, I just saw the error in the build log and didn't look close enough. Hmm, so the mdnsd stuff is not needed to build the host package. I think you need to specify the license for host-open62541 explicitly. And please add a comment, why this is necessary. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |