mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Lucas Sinn <Lucas.Sinn@wolfvision.net>
Cc: "ptxdist@pengutronix.de" <ptxdist@pengutronix.de>,
	Michael Tretter <m.tretter@pengutronix.de>
Subject: Re: [ptxdist] [PATCH] libsigcpp: Version bump 2.2.10 -> 3.6.0
Date: Thu, 12 Sep 2024 12:39:09 +0200	[thread overview]
Message-ID: <ZuLEzf_ptGjZtI8t@pengutronix.de> (raw)
In-Reply-To: <DU0PR08MB8185DAB4174BADB29154A89EE1642@DU0PR08MB8185.eurprd08.prod.outlook.com>

On Thu, Sep 12, 2024 at 10:29:30AM +0000, Lucas Sinn wrote:
> > On Tue, Sep 03, 2024 at 02:57:10PM +0200, Michael Tretter wrote:
> > > Hi Lucas,
> > >
> > > On Mon, 05 Aug 2024 19:14:04 +0200, Lucas Sinn wrote:
> > > > Updates.
> > > > https://github.com/libsigcplusplus/libsigcplusplus/releases/tag/3.6.
> > > > 0
> > >
> > > libsigcpp is marked as staging. The update should probably move it out 
> > > of staging, too.
> > 
> > Indeed. Please revert the commit that moved it to staging and squash it into this commit.
> > 
> > Also: It seems the tarball is missing the configure script, so you need to add a patches directory with an autogen.sh.
> > 
> > Michael
> 
> Got it. Will provide an updated patch shortly.
> When i look at the release tarball from GitHub there is a autogen.sh available. However
> the patch introduces meson as build system where the autogen.sh is not needed anymore.

Ah, I don't have the failed build log any more, but I think I didn't look
close enough. What failed was probably the host-libsigcpp package. You need
to convert that one as well. Then, the configure script is no longer
needed.

Michael

> > > > Signed-off-by: Lucas Sinn <lucas.sinn@wolfvision.net>
> > > > ---
> > > >  rules/libsigcpp.make | 25 +++++++++++++++++--------
> > > >  1 file changed, 17 insertions(+), 8 deletions(-)
> > > >
> > > > diff --git a/rules/libsigcpp.make b/rules/libsigcpp.make index 
> > > > db02f33d8..fc26d68de 100644
> > > > --- a/rules/libsigcpp.make
> > > > +++ b/rules/libsigcpp.make
> > > > @@ -15,10 +15,10 @@ PACKAGES-$(PTXCONF_LIBSIGCPP) += libsigcpp  #  # 
> > > > Paths and names  # -LIBSIGCPP_VERSION  := 2.2.10
> > > > -LIBSIGCPP_MD5              := 6d350ae0bc17b8915a06ce6b7e4240e8
> > > > +LIBSIGCPP_VERSION  := 3.6.0
> > > > +LIBSIGCPP_MD5              := b7205d5465ac15fbc0c781d39b4011be
> > > >  LIBSIGCPP          := libsigc++-$(LIBSIGCPP_VERSION)
> > > > -LIBSIGCPP_SUFFIX   := tar.bz2
> > > > +LIBSIGCPP_SUFFIX   := tar.xz
> > > >  LIBSIGCPP_URL              := $(call ptx/mirror, GNOME, libsigc++/$(basename $(LIBSIGCPP_VERSION))/$(LIBSIGCPP).$(LIBSIGCPP_SUFFIX))
> > > >  LIBSIGCPP_SOURCE   := $(SRCDIR)/$(LIBSIGCPP).$(LIBSIGCPP_SUFFIX)
> > > >  LIBSIGCPP_DIR              := $(BUILDDIR)/$(LIBSIGCPP)
> > > > @@ -28,12 +28,21 @@ LIBSIGCPP_DIR           := $(BUILDDIR)/$(LIBSIGCPP)
> > > >  # 
> > > > --------------------------------------------------------------------
> > > > --------
> > > >
> > > >  #
> > > > -# autoconf
> > > > +# meson
> > > >  #
> > > > -LIBSIGCPP_CONF_TOOL        := autoconf
> > > > +LIBSIGCPP_CONF_TOOL        := meson
> > > >  LIBSIGCPP_CONF_OPT := \
> > > > -   $(CROSS_AUTOCONF_USR) \
> > > > -   --disable-documentation
> > > > +   $(CROSS_MESON_USR) \
> > > > +   -Dbenchmark=false \
> > > > +   -Dbuild-deprecated-api=false \
> > > > +   -Dbuild-documentation=false \
> > > > +   -Dbuild-examples=false \
> > > > +   -Dbuild-pdf=false \
> > > > +   -Dbuild-tests=false \
> > > > +   -Ddist-warnings=fatal \
> > > > +   -Dmaintainer-mode=false \
> > > > +   -Dvalidation=false \
> > > > +   -Dwarnings=min
> > > >
> > > >  # 
> > > > --------------------------------------------------------------------
> > > > --------
> > > >  # Target-Install
> > > > @@ -48,7 +57,7 @@ $(STATEDIR)/libsigcpp.targetinstall:
> > > >     @$(call install_fixup, libsigcpp,AUTHOR,"Robert Schwebel <r.schwebel@pengutronix.de>")
> > > >     @$(call install_fixup, libsigcpp,DESCRIPTION,missing)
> > > >
> > > > -   @$(call install_lib, libsigcpp, 0, 0, 0644, libsigc-2.0)
> > > > +   @$(call install_lib, libsigcpp, 0, 0, 0644, libsigc-3.0)
> > > >
> > > >     @$(call install_finish, libsigcpp)
> > > >
> > > > --
> > > > 2.37.2
> > >
> > >
> > 
> > --
> > Pengutronix e.K.                           |                             |
> > Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> > 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> > Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> Lucas Sinn 
> R&D Engineer
> 
> WolfVision GmbH 
> Oberes Ried 14 | 6833 Klaus | Austria 
> Tel: +43 5523 52250 <tel:+43552352250> | Mail: lucas.sinn@wolfvision.net <mailto:lucas.sinn@wolfvision.net>
> 
> Website: wolfvision.com <www.wolfvision.com> 
> Firmenbuch / Commercial Register: FN283521v Feldkirch/Austria
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2024-09-12 10:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <016db821-bc16-4106-ab26-ac766a339fab.e0c24246-04d4-485f-8d5f-1cc8fbefd095.584524cf-9ed3-4b7b-b5cd-f62fc832ca66@emailsignatures365.codetwo.com>
2024-08-05 17:14 ` Lucas Sinn
2024-09-03 12:57   ` Michael Tretter
2024-09-09  8:36     ` Michael Olbrich
2024-09-12 10:29       ` Lucas Sinn
2024-09-12 10:39         ` Michael Olbrich [this message]
2024-09-12 11:12           ` Lucas Sinn
2024-09-12 11:16             ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZuLEzf_ptGjZtI8t@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=Lucas.Sinn@wolfvision.net \
    --cc=m.tretter@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox