Re: [ptxdist] [PATCH v3] glibmm: add new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Thu, Aug 08, 2024 at 06:02:07PM +0200, Lucas Sinn wrote:
> Signed-off-by: Lucas Sinn <lucas.sinn@wolfvision.net>
> ---
> Removed unnecessary usage meson cross file
> 
>  rules/glibmm.in   | 10 +++++++
>  rules/glibmm.make | 70 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 80 insertions(+)
>  create mode 100644 rules/glibmm.in
>  create mode 100644 rules/glibmm.make
> 
> diff --git a/rules/glibmm.in b/rules/glibmm.in
> new file mode 100644
> index 000000000..5b6e4646e
> --- /dev/null
> +++ b/rules/glibmm.in
> @@ -0,0 +1,10 @@
> +## SECTION=multimedia_gtk
> +
> +config GLIBMM
> +	tristate
> +	select HOST_MESON
> +	select GLIB
> +	select LIBSIGCPP
> +	prompt "glibmm"
> +	help
> +	  C++ wrapper for glib
> diff --git a/rules/glibmm.make b/rules/glibmm.make
> new file mode 100644
> index 000000000..f45dec55c
> --- /dev/null
> +++ b/rules/glibmm.make
> @@ -0,0 +1,70 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2024 by Lucas Sinn <lucas.sinn@wolfvision.net>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_GLIBMM) += glibmm
> +
> +#
> +# Paths and names
> +#
> +GLIBMM_VERSION	:= 2.78.1
> +GLIBMM_MD5	:= 52b93bf93de45e5a6b3c321bc832cd9c
> +GLIBMM		:= glibmm-$(GLIBMM_VERSION)
> +GLIBMM_SUFFIX	:= tar.xz
> +GLIBMM_URL	:= $(call ptx/mirror, GNOME, glibmm/$(basename $(GLIBMM_VERSION))/$(GLIBMM).$(GLIBMM_SUFFIX))
> +GLIBMM_SOURCE	:= $(SRCDIR)/$(GLIBMM).$(GLIBMM_SUFFIX)
> +GLIBMM_DIR	:= $(BUILDDIR)/$(GLIBMM)
> +GLIBMM_LICENSE	:= LGPL-2.1-only AND GPL-2.0-only
> +GLIBMM_LICENSE_FILES	:= \
> +	file://COPYING;md5=42dfffebc56fec7527aac53b7a89d1d8 \
> +	file://COPYING.tools;md5=751419260aa954499f7abaabaa882bbe
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# meson
> +#
> +GLIBMM_CONF_TOOL  := meson
> +GLIBMM_CONF_OPT   := \
> +        $(CROSS_MESON_USR) \
> +        -Dbuild-deprecated-api=false \
> +        -Dbuild-documentation=false \
> +        -Dbuild-examples=false \
> +        -Ddebug-refcounting=false \
> +        -Ddist-warnings=fatal \
> +        -Dmaintainer-mode=false \
> +        -Dmsvc14x-parallel-installable=false \
> +        -Dwarnings=max \
> +        \
> +        --cross-file $(GLIB_MESON_CROSS_FILE)

I'm pretty sure that this is not needed either. The special cross file for
glib defines extra variables for stuff that cannot be detected at build
time. These variables are specific to the glib meson files and I'm pretty
sure that they are not used here.

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/glibmm.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, glibmm)
> +	@$(call install_fixup, glibmm,PRIORITY,optional)
> +	@$(call install_fixup, glibmm,SECTION,base)
> +	@$(call install_fixup, glibmm,AUTHOR,"Lucas Sinn <lucas.sinn@wolfvision.net>")
> +	@$(call install_fixup, glibmm,DESCRIPTION,missing)
> +
> +	@$(call install_lib, glibmm, 0, 0, 0644, libglibmm-2.68)
> +	@$(call install_lib, glibmm, 0, 0, 0644, libgiomm-2.68)
> +
> +	@$(call install_finish, glibmm)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.37.2
> 
> 
> Lucas Sinn 
> R&D Engineer
> 
> Wolfvision GmbH 
> Oberes Ried 14 | 6833 Klaus | Austria 
> Tel: +43 5523 52250 <tel:+43552352250> | Mail: lucas.sinn@wolfvision.net <mailto:lucas.sinn@wolfvision.net>
> 
> Website: wolfvision.com <www.wolfvision.com> 
> Firmenbuch / Commercial Register: FN283521v Feldkirch/Austria
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |