From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 03 Sep 2024 14:55:05 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1slT3p-000s9W-27 for lore@lore.pengutronix.de; Tue, 03 Sep 2024 14:55:05 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1slT3o-0005sT-77; Tue, 03 Sep 2024 14:55:04 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1slT3S-0005s9-Qp; Tue, 03 Sep 2024 14:54:42 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1slT3S-005CXU-3c; Tue, 03 Sep 2024 14:54:42 +0200 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1slT3S-004RGE-04; Tue, 03 Sep 2024 14:54:42 +0200 Date: Tue, 3 Sep 2024 14:54:41 +0200 From: Michael Tretter To: ptxdist@pengutronix.de Message-ID: References: <010201919dedf670-fb51031f-4588-459a-965b-b272683a339f-000000@eu-west-1.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <010201919dedf670-fb51031f-4588-459a-965b-b272683a339f-000000@eu-west-1.amazonses.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] weston: build color management module X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Benjamin Gaignard Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi Benjamin, On Thu, 29 Aug 2024 11:38:23 +0000, Benjamin Gaignard wrote: > If LCMS package dependency is selected build weston color management > module. > > Signed-off-by: Benjamin Gaignard > --- > rules/weston.in | 1 + > rules/weston.make | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/rules/weston.in b/rules/weston.in > index 10f0e9172..22752aef0 100644 > --- a/rules/weston.in > +++ b/rules/weston.in > @@ -40,6 +40,7 @@ menuconfig WESTON > select PIPEWIRE if WESTON_BACKEND_PIPEWIRE > select NEATVNC if WESTON_BACKEND_VNC > select PAM if WESTON_BACKEND_VNC > + select LCMS > prompt "weston " > help > Wayland compositor reference implementation > diff --git a/rules/weston.make b/rules/weston.make > index 35ddab180..908f76f0b 100644 > --- a/rules/weston.make > +++ b/rules/weston.make > @@ -45,7 +45,7 @@ WESTON_CONF_OPT := \ > -Dbackend-vnc=$(call ptx/truefalse,PTXCONF_WESTON_BACKEND_VNC) \ > -Dbackend-wayland=$(call ptx/truefalse,PTXCONF_WESTON_GL) \ > -Dbackend-x11=false \ > - -Dcolor-management-lcms=false \ > + -Dcolor-management-lcms=$(call ptx/truefalse, PTXCONF_LCMS) \ With this change, it's not possible to build Weston without color-management-lcms, because PTXCONF_LCMS is always selected and this always will be set to true. Please add a separate option PTXCONF_WESTON_COLOR_MANAGEMENT_LCMS (or similar) that enables this option, and select LCMS only if PTXCONF_WESTON_COLOR_MANAGEMENT_LCMS is set. Michael > -Ddemo-clients=$(call ptx/truefalse,PTXCONF_WESTON_IVISHELL_EXAMPLE) \ > -Ddeprecated-color-management-colord=false \ > -Ddeprecated-color-management-static=false \ > -- > 2.43.0 > > >