From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 26 Aug 2024 08:53:51 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1siTbr-00DVb3-0x for lore@lore.pengutronix.de; Mon, 26 Aug 2024 08:53:51 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1siTbq-0001pv-0L; Mon, 26 Aug 2024 08:53:50 +0200 Received: from h2.cmg2.smtp.forpsi.com ([81.2.195.189]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1siTbV-0001pS-Cf for ptxdist@pengutronix.de; Mon, 26 Aug 2024 08:53:31 +0200 Received: from lenoch ([91.218.190.200]) by cmgsmtp with ESMTPSA id iTbQsi09hRhHFiTbRsjLOv; Mon, 26 Aug 2024 08:53:28 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=triops.cz; s=f2019; t=1724655208; bh=0XFizJFgWBR0oB5GT6xDCPMzZNzBGvu8TLiPMTm1Kuo=; h=Date:From:To:Subject:Message-ID:MIME-Version:Content-Type; b=WvMI//90ttdGrbBTCPAhHaxUVwAzasgyrWsbaLFujtFgzeb60HKwt7QUjHsqA7Hc6 5FESiHPdA/FJ4+ySZPNTLHr0g2T22ZNGoJFlo+MYkgXOBPEQuUcjt1ROPkLvzBh5yT uZ2pUoGQEAIwJc+AT3dfUplcvcpVl9FOyrCovgOlHyYCJT5Q1CsKSvuHeIkbM2XxZ1 eu1/MCyY+7BYDsrjvoVFiyjamQ05VeRY64KCPqVlvB6334naupzJc+lcaQtN5gsOFl fkiRzmctnU7nnYGi8Ih5Mxz3kMlv6n0RvWA4a2PvqFaHiTza/QqwI0kSw+A1mlEHha 78XzOgyZ26lpw== Date: Mon, 26 Aug 2024 08:53:24 +0200 From: Ladislav Michl To: ptxdist@pengutronix.de Message-ID: References: <20230105072635.GC20148@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230105072635.GC20148@pengutronix.de> X-CMAE-Envelope: MS4xfP8l9DVM4hAlWtS3zFN87+iqHYvcdfhBYwjwsItcUzn/F+u80OEUDR7nroi1FUklXrtgbr6EKbzCkZy3RH6fbVIRcAYrKgJuxlJoetVkx4eZc+J/n6qb iBWTCk6YL2S3+tVtAYT9qA7uyRJnDETR9gvcchLFiUN2WOCxPctTEX1c6UhCqW9Q6HG8ubLkBldbxA== X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.4 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [ptxdist] [RFC] Do not select INITMETHOD X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Thu, Jan 05, 2023 at 08:26:35AM +0100, Michael Olbrich wrote: > On Wed, Jan 04, 2023 at 03:47:43PM +0100, Ladislav Michl wrote: > > Do not force INITMETHOD to allow BSPs to use alternative inits > > on their own (minit for example) > > > > Now that initmethod.in part of patch is questionable, but it breaks > > various ways without it, for example: > > WARNING: unmet direct dependencies detected for RC_ONCE > > Depends on [n]: INITMETHOD [=n] > > Selected by [m]: > > - DROPBEAR [=m] && RUNTIME [=y] > > > > Any other ideas? > > I think it should be possible to add a > > source "generated/initmethod-choice.in" > > (name TBD) inside the initmethod choice. This way you can add your own > initmethod instead of disabling it. Maybe split the existing ones into > separate files for consistency. Ok, the name really needs to be decided and existing initmethods splitted between files, otherwise when no custom init exists: rules/initmethod.in:34: can't open file "generated/initmethod_provider.in" Here the name is based on platforms/code-signing.in, but that is also inconsistent as other initmethod related files are using '-' and not '_'. What is recommended name then? ladis > Regards, > Michael > > > Thak you, > > ladis > > --- > > rules/dropbear.in | 1 - > > rules/initmethod.in | 4 ++-- > > rules/lldpd.in | 1 - > > 3 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/rules/dropbear.in b/rules/dropbear.in > > index 95beb09bf..7b5736696 100644 > > --- a/rules/dropbear.in > > +++ b/rules/dropbear.in > > @@ -6,7 +6,6 @@ menuconfig DROPBEAR > > select LIBC_UTIL > > select LIBC_CRYPT > > select GCCLIBS_GCC_S > > - select INITMETHOD > > select RC_ONCE if RUNTIME > > select BUSYBOX_START_STOP_DAEMON if DROPBEAR_STARTSCRIPT > > select BUSYBOX_FEATURE_START_STOP_DAEMON_FANCY if DROPBEAR_STARTSCRIPT > > diff --git a/rules/initmethod.in b/rules/initmethod.in > > index 489fd365d..4066a05ba 100644 > > --- a/rules/initmethod.in > > +++ b/rules/initmethod.in > > @@ -33,6 +33,6 @@ choice > > > > endchoice > > > > -source "generated/initmethod.in" > > - > > endif > > + > > +source "generated/initmethod.in" > > diff --git a/rules/lldpd.in b/rules/lldpd.in > > index 8b253ba83..d2afccbd0 100644 > > --- a/rules/lldpd.in > > +++ b/rules/lldpd.in > > @@ -3,7 +3,6 @@ > > menuconfig LLDPD > > tristate > > prompt "lldpd " > > - select INITMETHOD > > select LIBBSD > > select LIBCAP > > select LIBEVENT > > -- > > 2.32.0 > > > > > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |