From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 02 Aug 2024 10:05:19 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sZnHr-005OxK-0K for lore@lore.pengutronix.de; Fri, 02 Aug 2024 10:05:19 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sZnHq-0007s3-Mn; Fri, 02 Aug 2024 10:05:18 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sZnHe-0007ri-32; Fri, 02 Aug 2024 10:05:06 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sZnHd-003xTW-ME; Fri, 02 Aug 2024 10:05:05 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sZnHd-00CXC8-24; Fri, 02 Aug 2024 10:05:05 +0200 Date: Fri, 2 Aug 2024 10:05:05 +0200 From: Michael Olbrich To: Bruno Thomsen Message-ID: References: <20240716195944.4611-1-bruno.thomsen@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240716195944.4611-1-bruno.thomsen@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] ptxd_make_get: verbose on wget X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Tue, Jul 16, 2024 at 09:59:44PM +0200, Bruno Thomsen wrote: > Change wget progress to none when verbose is chosen, > so it's possible to see download URLs. > > Tested on GNU Wget2 2.1.0 (Fedora 40). > > Signed-off-by: Bruno Thomsen > --- > Indentation just follow the style around existing if statement. > > scripts/lib/ptxd_make_get.sh | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/scripts/lib/ptxd_make_get.sh b/scripts/lib/ptxd_make_get.sh > index 4951abe5a..5e2152b36 100644 > --- a/scripts/lib/ptxd_make_get.sh > +++ b/scripts/lib/ptxd_make_get.sh > @@ -94,7 +94,9 @@ ptxd_make_get_http() { > return > elif [ ! -e "${path}" ]; then > temp_file="$(mktemp "${path}.XXXXXXXXXX")" || ptxd_bailout "failed to create tempfile" > - if [ -n "${PTXDIST_QUIET}" ]; then > + if [ "${PTXDIST_VERBOSE}" == "1" ]; then > + progress=none That is not supported by wget 1.x so this needs a version check. Michael > + elif [ -n "${PTXDIST_QUIET}" ]; then > progress=dot > else > progress=bar:force > > base-commit: 8c653b78e0052755fa9eca1579199568d7cf4e4a > -- > 2.45.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |