mailarchive of the ptxdist mailing list
 help / color / mirror / Atom feed
From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Lucas Stach <l.stach@pengutronix.de>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 07/20] figlet: replace URL with HTTPS
Date: Thu, 13 Jun 2024 10:05:51 +0200	[thread overview]
Message-ID: <ZmqoXwQ1fZNQH7AO@pengutronix.de> (raw)
In-Reply-To: <20240612-undead-remover-b8858c6675ad@thorsis.com>

On Wed, Jun 12, 2024 at 02:32:59PM +0200, Alexander Dahl wrote:
> Hei hei,
> 
> sorry for being late to the party, but we just discussed this in IRC …
> 
> Am Tue, May 14, 2024 at 10:35:39PM +0200 schrieb Lucas Stach:
> > As the figlet page only provides FTP downloads, point the download
> > URL to the github repository of the maintainer, which is also linked
> > from the homepage.
> > 
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> >  rules/figlet.make | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/rules/figlet.make b/rules/figlet.make
> > index 3dad77154430..c6d2fb38ea06 100644
> > --- a/rules/figlet.make
> > +++ b/rules/figlet.make
> > @@ -20,7 +20,7 @@ FIGLET_VERSION		:= 2.2.5
> >  FIGLET_MD5		:= d88cb33a14f1469fff975d021ae2858e
> >  FIGLET			:= figlet-$(FIGLET_VERSION)
> >  FIGLET_SUFFIX		:= tar.gz
> > -FIGLET_URL		:= ftp://ftp.figlet.org/pub/figlet/program/unix/$(FIGLET).$(FIGLET_SUFFIX)
> > +FIGLET_URL		:= https://github.com/cmatsuoka/figlet/archive/refs/tags/$(FIGLET_VERSION).$(FIGLET_SUFFIX)
> 
> This is replacing a probably handcrafted tarball from 10+ years ago
> with a machine generated tarball from today.  Although the content
> looks similar, the md5sum is not the same.
> 
> What about using this instead?
> 
> http://ftp.figlet.org/pub/figlet/program/unix/figlet-2.2.5.tar.gz

For the record: I decided to add the md5sum for the new tarball instead.

Michael

> >  FIGLET_SOURCE		:= $(SRCDIR)/$(FIGLET).$(FIGLET_SUFFIX)
> >  FIGLET_DIR		:= $(BUILDDIR)/$(FIGLET)
> >  FIGLET_LICENSE		:= BSD-3-clause
> > -- 
> > 2.39.2
> > 
> > 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |



  reply	other threads:[~2024-06-13  8:06 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-14 20:35 [ptxdist] [PATCH 00/20] remove FTP support Lucas Stach
2024-05-14 20:35 ` [ptxdist] [PATCH 01/20] alsa-lib: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 02/20] alsa-utils: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 03/20] ckermit: replace download URL with HTTP Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 04/20] dialog: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 05/20] efax: replace download URL with HTTPS Lucas Stach
2024-05-15  6:25   ` Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 06/20] fftw: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 07/20] figlet: replace URL with HTTPS Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-06-12 12:32   ` [ptxdist] [PATCH 07/20] " Alexander Dahl
2024-06-13  8:05     ` Michael Olbrich [this message]
2024-05-14 20:35 ` [ptxdist] [PATCH 08/20] gdb: remove FTP URL Lucas Stach
2024-05-15  5:52   ` Alexander Dahl
2024-05-15  6:27   ` Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 09/20] gdbserver: " Lucas Stach
2024-05-15  5:53   ` Alexander Dahl
2024-05-15  6:27   ` Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 10/20] glu: replace download URL with HTTPS Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 11/20] gnupg: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 12/20] libffi: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 13/20] libgpg-error: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 14/20] libksba: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 15/20] mesa-demos: replace download URL with HTTPS Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 16/20] netkit-ftp: remove FTP URL Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 17/20] npth: " Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 18/20] nvmetcli: version bump 0.7 -> 0.8 Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 19/20] proftpd: move to staging Lucas Stach
2024-05-21  9:59   ` [ptxdist] [APPLIED] " Michael Olbrich
2024-05-14 20:35 ` [ptxdist] [PATCH 20/20] ptxd_make_get: remove FTP support Lucas Stach
2024-05-15  6:38   ` Michael Olbrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZmqoXwQ1fZNQH7AO@pengutronix.de \
    --to=m.olbrich@pengutronix.de \
    --cc=l.stach@pengutronix.de \
    --cc=ptxdist@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox