From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 23 May 2024 08:48:52 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sA2Fw-00Ep8c-31 for lore@lore.pengutronix.de; Thu, 23 May 2024 08:48:52 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sA2Fw-0001Kh-KO; Thu, 23 May 2024 08:48:52 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sA2Fr-0001KK-Kr; Thu, 23 May 2024 08:48:47 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sA2Fr-002crK-8T; Thu, 23 May 2024 08:48:47 +0200 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sA2Fr-009iQe-0a; Thu, 23 May 2024 08:48:47 +0200 Date: Thu, 23 May 2024 08:48:47 +0200 From: Michael Olbrich To: r.czerwinski@pengutronix.de Message-ID: Mail-Followup-To: r.czerwinski@pengutronix.de, ptxdist@pengutronix.de References: <20240522142554.287231-1-r.czerwinski@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240522142554.287231-1-r.czerwinski@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] rauc: optional rauc-mark-good.service installation X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Wed, May 22, 2024 at 04:25:54PM +0200, r.czerwinski@pengutronix.de wrote: > From: Rouven Czerwinski > > Make the installation and enablement of the ruac-mark-good.service > optional. This is useful for BSPs which have the application indicate if > startup was successful instead of indicating succesful startup using the > rauc-mark-good-service. > > Signed-off-by: Rouven Czerwinski > --- > rules/rauc.in | 10 ++++++++++ > rules/rauc.make | 2 ++ > 2 files changed, 12 insertions(+) > > diff --git a/rules/rauc.in b/rules/rauc.in > index ee9c3f955..c65e3f04f 100644 > --- a/rules/rauc.in > +++ b/rules/rauc.in > @@ -46,6 +46,16 @@ config RAUC_SERVICE > that communicate with each other via D-Bus interface. > Only deactivate this if you have a system that does not provide D-Bus! > > +config RAUC_MARK_GOOD > + bool depends on INITMETHOD_SYSTEMD Michael > + prompt "Enable systemd mark-good service" > + default y > + help > + Installs and enables the default rauc-mark-good.service shipped with rauc. > + The rauc-mark-good.service runs when the systemd has successfully started > + up, which is not desirable if the application indicates the succesful > + startup. > + > config RAUC_NETWORK > bool > prompt "Enable network support" > diff --git a/rules/rauc.make b/rules/rauc.make > index 38577f94d..7aed77e89 100644 > --- a/rules/rauc.make > +++ b/rules/rauc.make > @@ -95,10 +95,12 @@ ifdef PTXCONF_INITMETHOD_SYSTEMD > @$(call install_alternative, rauc, 0, 0, 0644, \ > /usr/lib/systemd/system/rauc.service) > > +ifdef PTXCONF_RAUC_MARK_GOOD > @$(call install_alternative, rauc, 0, 0, 0644, \ > /usr/lib/systemd/system/rauc-mark-good.service) > @$(call install_link, rauc, ../rauc-mark-good.service, \ > /usr/lib/systemd/system/multi-user.target.wants/rauc-mark-good.service) > +endif > else > @$(call install_copy, rauc, 0, 0, 0755, -, \ > /usr/libexec/rauc-service.sh) > -- > 2.44.0 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |