Re: [ptxdist] [PATCH 02/13] nanopb: new package: tiny protobuf implementation

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, May 22, 2024 at 11:15:32PM +0200, Roland Hieber wrote:
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  rules/nanopb.in   | 12 ++++++++++++
>  rules/nanopb.make | 49 +++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 61 insertions(+)
>  create mode 100644 rules/nanopb.in
>  create mode 100644 rules/nanopb.make
> 
> diff --git a/rules/nanopb.in b/rules/nanopb.in
> new file mode 100644
> index 000000000000..ca3ac1b2c1d8
> --- /dev/null
> +++ b/rules/nanopb.in
> @@ -0,0 +1,12 @@
> +## SECTION=system_libraries
> +
> +config NANOPB
> +	tristate
> +	select HOST_CMAKE
> +	select HOST_SYSTEM_PYTHON3
> +	select HOST_PROTOBUF
> +	prompt "nanopb"
> +	help
> +	  Nanopb is a plain-C implementation of Google's Protocol Buffers data
> +	  format. It is targeted at 32 bit microcontrollers, but is also fit for
> +	  other embedded systems with tight memory constraints.
> diff --git a/rules/nanopb.make b/rules/nanopb.make
> new file mode 100644
> index 000000000000..808c26b917e5
> --- /dev/null
> +++ b/rules/nanopb.make
> @@ -0,0 +1,49 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2024 by Roland Hieber <rhi@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_NANOPB) += nanopb
> +
> +#
> +# Paths and names
> +#
> +NANOPB_VERSION		:= 0.4.8
> +NANOPB_MD5		:= 7c5305add7bf70b915c6eb1dc50cc20f
> +NANOPB			:= nanopb-$(NANOPB_VERSION)
> +NANOPB_SUFFIX		:= tar.gz
> +NANOPB_URL		:= https://jpa.kapsi.fi/nanopb/download//$(NANOPB).$(NANOPB_SUFFIX)

Remove double /.

> +NANOPB_SOURCE		:= $(SRCDIR)/$(NANOPB).$(NANOPB_SUFFIX)
> +NANOPB_DIR		:= $(BUILDDIR)/$(NANOPB)
> +NANOPB_LICENSE		:= Zlib
> +NANOPB_LICENSE_FILES	:= file://LICENSE.txt;md5=9db4b73a55a3994384112efcdb37c01f
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +NANOPB_CONF_ENV	:= $(CROSS_ENV)

Remove, it's the default.

> +
> +#
> +# cmake
> +#
> +NANOPB_CONF_TOOL	:= cmake
> +NANOPB_CONF_OPT		:= \
> +	$(CROSS_CMAKE_USR)
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +# Note: the package installs only headers, generators, and static libraries
> +$(STATEDIR)/nanopb.targetinstall:
> +	@$(call targetinfo)
> +	@$(call touch)

The default targetinstall stage is empty, so just remove it here.

Michael

> +
> +# vim: syntax=make
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |