From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 15 Mar 2024 13:01:02 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rl6FC-007pQ4-0D for lore@lore.pengutronix.de; Fri, 15 Mar 2024 13:01:02 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rl6FB-0006Fg-Ox; Fri, 15 Mar 2024 13:01:01 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rl6F2-0006FV-9l for ptxdist@pengutronix.de; Fri, 15 Mar 2024 13:00:52 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rl6F1-006UhF-Tq for ptxdist@pengutronix.de; Fri, 15 Mar 2024 13:00:51 +0100 Received: from pza by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rl6F1-0011qV-2j for ptxdist@pengutronix.de; Fri, 15 Mar 2024 13:00:51 +0100 Date: Fri, 15 Mar 2024 13:00:51 +0100 From: Philipp Zabel To: ptxdist@pengutronix.de Message-ID: References: <20240308115756.271085-1-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH 1/2] opus: version bump 1.4 -> 1.5.1 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Fri, Mar 15, 2024 at 07:19:24AM +0100, Michael Olbrich wrote: > On Fri, Mar 08, 2024 at 12:57:55PM +0100, Philipp Zabel wrote: > > https://opus-codec.org/demo/opus-1.5/ > > > > New features optional, enabling DRED, deep PLC, and OSCE increases > > the library size by a few MiB. > > > > Signed-off-by: Philipp Zabel > > --- > > rules/opus.in | 20 ++++++++++++++++++-- > > rules/opus.make | 11 +++++++++-- > > 2 files changed, 27 insertions(+), 4 deletions(-) > > > > diff --git a/rules/opus.in b/rules/opus.in > > index 7412eb76a538..3b8e6444cd3e 100644 > > --- a/rules/opus.in > > +++ b/rules/opus.in > > @@ -1,7 +1,23 @@ > > ## SECTION=multimedia_libs > > > > -config OPUS > > +menuconfig OPUS > > tristate > > - prompt "opus" > > + prompt "opus " > > help > > Opus is a totally open, royalty-free, highly versatile audio codec. > > + > > +if OPUS > > + > > +config OPUS_DRED > > + bool > > + prompt "enable deep redundancy (DRED)" > > + > > +config OPUS_DEEP_PLC > > + bool > > + prompt "enable deep packet loss concealment (PLC)" > > + > > +config OPUS_OSCE > > + bool > > + prompt "enable opus speech coding enhancement (OSCE)" > > What's the reason for making these optional? I'd prefer to just hardcode > whatever everybody else is doing unless there is a good reason to make > these optional. And in that case, the options need a help text to help > decide what to choose. I wouldn't know what to do by just looking at these > options. Enabling the new ML features increases the library size by about 5 MiB (2 MiB for DRED + 1 MiB for deep PLC, and 1 MiB 1.6 MiB for OSCE, according to the blog post). DRED and deep PLC are supposed to improve voice quality under packet loss, OSCE at low bitrates. regards Philipp