Re: [ptxdist] [PATCH 1/2] opus: version bump 1.4 -> 1.5.1

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Fri, Mar 08, 2024 at 12:57:55PM +0100, Philipp Zabel wrote:
> https://opus-codec.org/demo/opus-1.5/
> 
> New features optional, enabling DRED, deep PLC, and OSCE increases
> the library size by a few MiB.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  rules/opus.in   | 20 ++++++++++++++++++--
>  rules/opus.make | 11 +++++++++--
>  2 files changed, 27 insertions(+), 4 deletions(-)
> 
> diff --git a/rules/opus.in b/rules/opus.in
> index 7412eb76a538..3b8e6444cd3e 100644
> --- a/rules/opus.in
> +++ b/rules/opus.in
> @@ -1,7 +1,23 @@
>  ## SECTION=multimedia_libs
>  
> -config OPUS
> +menuconfig OPUS
>  	tristate
> -	prompt "opus"
> +	prompt "opus                          "
>  	help
>  	  Opus is a totally open, royalty-free, highly versatile audio codec.
> +
> +if OPUS
> +
> +config OPUS_DRED
> +	bool
> +	prompt "enable deep redundancy (DRED)"
> +
> +config OPUS_DEEP_PLC
> +	bool
> +	prompt "enable deep packet loss concealment (PLC)"
> +
> +config OPUS_OSCE
> +	bool
> +	prompt "enable opus speech coding enhancement (OSCE)"

What's the reason for making these optional? I'd prefer to just hardcode
whatever everybody else is doing unless there is a good reason to make
these optional. And in that case, the options need a help text to help
decide what to choose. I wouldn't know what to do by just looking at these
options.

Michael

> +
> +endif
> diff --git a/rules/opus.make b/rules/opus.make
> index 4dd2f9d9b653..ea1f04837cf1 100644
> --- a/rules/opus.make
> +++ b/rules/opus.make
> @@ -14,8 +14,8 @@ PACKAGES-$(PTXCONF_OPUS) += opus
>  #
>  # Paths and names
>  #
> -OPUS_VERSION	:= 1.4
> -OPUS_MD5	:= 0d89c15268c5c5984f583d7997d2a148
> +OPUS_VERSION	:= 1.5.1
> +OPUS_MD5	:= 06c0e626ea3ad72f7b006e9130c8b15d
>  OPUS		:= opus-$(OPUS_VERSION)
>  OPUS_SUFFIX	:= tar.gz
>  OPUS_URL	:= http://downloads.xiph.org/releases/opus/$(OPUS).$(OPUS_SUFFIX)
> @@ -38,6 +38,9 @@ OPUS_CONF_OPT	:= \
>  	--disable-fixed-point-debug \
>  	--enable-float-api \
>  	--disable-custom-modes \
> +	--$(call ptx/endis, PTXCONF_OPUS_DRED)-dred \
> +	--$(call ptx/endis, PTXCONF_OPUS_DEEP_PLC)-deep-plc \
> +	--disable-lossgen \
>  	--enable-float-approx \
>  	--enable-asm \
>  	--enable-rtcd \
> @@ -47,6 +50,10 @@ OPUS_CONF_OPT	:= \
>  	--disable-fuzzing \
>  	--disable-check-asm \
>  	--disable-doc \
> +	--disable-dot-product \
> +	--disable-dnn-debug-float \
> +	--disable-osce-training-data \
> +	--$(call ptx/endis, PTXCONF_OPUS_OSCE)-osce \
>  	--disable-extra-programs \
>  	--enable-rfc8251
>  
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |