From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Simon Falsig <sfalsig@verity.net>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 1/3] RFC: ptxd_make_world: Extract CPE for packages
Date: Mon, 4 Mar 2024 17:18:06 +0100 [thread overview]
Message-ID: <ZeX0Ptyn0bYfPdZY@pengutronix.de> (raw)
In-Reply-To: <20240219165617.70971-1-sfalsig@verity.net>
On Mon, Feb 19, 2024 at 05:56:15PM +0100, Simon Falsig wrote:
> If a package specifies a CPE or CPE_VENDOR and CPE_PRODUCT, this is
> extracted into the fast report for that package. If no CPE is
> specified, or not both of CPE_VENDOR and CPE_PRODUCT, then no value is
> added.
>
> By default, the existing VERSION is used, but can be overridden with
> CPE_VERSION.
>
> Constructed CPEs are validated against the official CPE regex.
>
> The CPE (Common Platform Enumerator) allows matching CVEs to specific
> packages, and see if these apply to a specific deployment.
So we need to change the plan on how to do this a bit. I've looked into
this stuff some more. Specifically what yocto is doing here. This is a bit
of a mess. Take a look at this[1]:
[...]
CVE_PRODUCT = "haxx:curl haxx:libcurl curl:curl curl:libcurl libcurl:libcurl daniel_stenberg:curl"
[...]
There are packages that need multiple vendor/product combinations :-/. So
the product is a list. And if an entry contains a ':' then it's
<vendor>:<product>. Otherwise '*' is used for the vendor.
And please use _CVE_PRODUCT (instead of _CPE_PRODUCT) so it's called the
same.
[1] https://git.openembedded.org/openembedded-core/tree/meta/recipes-support/curl/curl_8.6.0.bb?id=efebd6a8824769137a21674e2bfe1c059a41758a#n20
> ---
> rules/post/ptxd_make_world_common.make | 4 ++++
> scripts/lib/ptxd_make_world_report.sh | 9 +++++++++
> 2 files changed, 13 insertions(+)
>
> diff --git a/rules/post/ptxd_make_world_common.make b/rules/post/ptxd_make_world_common.make
> index 4b6f691b6..189bc4ec9 100644
> --- a/rules/post/ptxd_make_world_common.make
> +++ b/rules/post/ptxd_make_world_common.make
> @@ -80,6 +80,10 @@ world/env/impl = \
> pkg_PKG="$(call ptx/escape,$(1))" \
> pkg_pkg="$(call ptx/escape,$($(1)))" \
> pkg_version="$(call ptx/escape,$($(1)_VERSION))" \
> + pkg_cpe_vendor="$(call ptx/escape,$($(1)_CPE_VENDOR))" \
> + pkg_cpe_product="$(call ptx/escape,$($(1)_CPE_PRODUCT))" \
> + pkg_cpe_version="$(call ptx/escape,$($(1)_CPE_VERSION))" \
> + pkg_cpe="$(call ptx/escape,$($(1)_CPE))" \
> pkg_config="$(call ptx/escape,$($(1)_CONFIG))" \
> pkg_ref_config="$(call ptx/escape,$($(1)_REF_CONFIG))" \
> pkg_cargo_lock="$(call ptx/escape,$($(1)_CARGO_LOCK))" \
> diff --git a/scripts/lib/ptxd_make_world_report.sh b/scripts/lib/ptxd_make_world_report.sh
> index 2c02e81f7..37fa2b89e 100644
> --- a/scripts/lib/ptxd_make_world_report.sh
> +++ b/scripts/lib/ptxd_make_world_report.sh
> @@ -72,6 +72,15 @@ ptxd_make_world_report_yaml() {
> do_list "rundeps:" "${pkg_run_deps}"
> do_echo "config:" "${pkg_config}"
> do_echo "version:" "${pkg_version}"
> + if [ ! -n "${pkg_cpe_version}" -a ! -n "${pkg_cpe}" ]; then
> + # Default to using pkg_version for the CPE string, unless _CPE_VERSION or _CPE are explicitly
> + # specified. In the case of the latter, there's no need to keep track of the version separately.
> + pkg_cpe_version="${pkg_version}"
> + fi
don't do this here. This fallback should be handled in the script.
> + do_echo "cpe:" "${pkg_cpe}"
This should be a list in case we need more than one.
> + do_echo "cpe_vendor:" "${pkg_cpe_vendor}"
Same here as described above.
Michael
> + do_echo "cpe_product:" "${pkg_cpe_product}"
> + do_echo "cpe_version:" "${pkg_cpe_version}"
> do_list "url:" "${pkg_url}"
> do_echo "md5:" "${pkg_md5}"
> do_echo "source:" "${pkg_src}"
> --
> 2.25.1
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2024-03-04 16:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 16:56 Simon Falsig
2024-02-19 16:56 ` [ptxdist] [PATCH 2/3] RFC: Add CPE for a few packages Simon Falsig
2024-02-19 16:56 ` [ptxdist] [PATCH 3/3] RFC: sbom_report: Add support Simon Falsig
2024-03-04 17:27 ` Michael Olbrich
2024-03-04 16:18 ` Michael Olbrich [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-09-13 16:05 [ptxdist] [PATCH 1/3] RFC: ptxd_make_world: Extract CPE for packages Simon Falsig
2023-09-13 21:16 ` Christian Melki
2023-09-14 6:46 ` Simon Falsig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeX0Ptyn0bYfPdZY@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=sfalsig@verity.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox