From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 10 Jan 2024 08:52:06 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rNTNe-00BMFP-00 for lore@lore.pengutronix.de; Wed, 10 Jan 2024 08:52:06 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rNTNd-00064y-QJ; Wed, 10 Jan 2024 08:52:05 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNTNO-00064m-74; Wed, 10 Jan 2024 08:51:50 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNTNN-001ea3-Kf; Wed, 10 Jan 2024 08:51:49 +0100 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNTNN-009xGU-1o; Wed, 10 Jan 2024 08:51:49 +0100 Date: Wed, 10 Jan 2024 08:51:49 +0100 From: Michael Olbrich To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , ruggero , ptxdist@pengutronix.de References: <20240108131457.604dc6c4@Laptop-RR> <76c12c66-efa8-4f02-a6d6-5204271806a3@t2data.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <76c12c66-efa8-4f02-a6d6-5204271806a3@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] Difficulties to compile package utils-linux while upgrading from PTXDIST-2023.09.0 to PTXDIST-2023.19.0. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ruggero , ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi, On Mon, Jan 08, 2024 at 01:47:57PM +0100, Christian Melki wrote: > On 1/8/24 1:14 PM, ruggero wrote: > > [Du f?r inte e-post ofta fr?n rrossi@atb-biomag.de. L?s om varf?r det h?r ?r viktigt p? https://aka.ms/LearnAboutSenderIdentification ] > > > > Hello everybody, > > > > > > my BSP still uses an old version of linux / libC, that does not provide > > all modern features. > > > > Compiling utils-linux with PTXDIST-2023.09.0 was painless. > > Upgrading to PTXDIST-2023.11.0 caused several compilation errors. > > > > Both PTXDIST release uses the same version of utils-linux (2.39.2) the > > only difference being the build system. PTXDIST-2023.09.0 uses autotools, > > while PTXDIST-2023.11.0 uses meson. > > > > Here a list of the problems: > > > > My linux do not provide . This causes an error while > > compiling blkzone. > > > > My linux do not provide . This causes an error compiling blkpr. > > > > My linux do not provide . This causes an error compiling > > lsfd. > > > > My linux do not provide the symbol SIOCGSKNS in linux/sockios.h. This > > causes an error while compiling test_mkfds. > > > > In the autotool version, all these programs were disabled. This seems to > > be not possible with meson. > > > > My libC provides the symbol openpty in the libutils module. The > > PTXDIST-2023.09.0 makefile util-linux.make explicitly enables libutils, > > the PTXDIST-2023.11.0 explicitly disables them. > > > > I was able to find a solution to all the problems. Attached are my patches. > > > > In meson.build I disabled build of blkzone if linux/blkzoned.h does not > > exists, lsfd if linux/pr.h is missing, etc. > > > > In the makefile util-linux.make I just changed libutils form disabled to > > enabled. Maybe one can consider to use a parameter instead. > > > > I'm not sure if this is the best way to do, since it is my first > > experience with meson. It would be nice if somebody can check them, and > > maybe include them in the future versions of ptxdist. > > > > Thanks for reporting and working with these issues. > I suggest also reporting them upstream to the util-linux project itself. > There are going to be a lot of these types of issues. > Ie when converting build systems, be it autotools or anything else. Reporting to upstream is definitely good idea. But I'm not sure if will accept patches for kernel / libc versions that are this old. You could also try to use newer kernel headers instead. That way util-linux should compile, even if some tools may fail at runtime. To do that enable the package KERNEL_HEADERS and make sure the new headers are used in util-linux.make. See e.g. systemd.make on how to do that. It's the "ifdef PTXCONF_KERNEL_HEADER" block that you'll need to copy and adapt. I would accept a patch for this, but please read our contributing guide lines[1] on how to do that. Regards, Michael [1] https://www.ptxdist.org/doc/contributing.html > Regards, > Christian > > > > > > > Ruggero > > > > > > > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |