Re: [ptxdist] [EXT] [PATCH] host-dtc: set make env

Re: [ptxdist] [EXT] [PATCH] host-dtc: set make env

[Denis OSTERLAND-HEIM]

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

Hi,

what about using the target parameters here?
HOST_DTC_MAKE_OPT = $(DTC_MAKE_OPT)
HOST_DTC_INSTALL_OPT = $(DTC_INSTALL_OPT)

Regards, Denis

-----Original Message-----
From: ptxdist <ptxdist-bounces@pengutronix.de> On Behalf Of Ladislav Michl
Sent: Friday, January 5, 2024 1:13 PM
To: ptxdist@pengutronix.de
Subject: [EXT] [ptxdist] [PATCH] host-dtc: set make env

[EXTERNAL EMAIL]
 

From: Ladislav Michl <ladis@linux-mips.org>

Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
---
 rules/host-dtc.make | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/rules/host-dtc.make b/rules/host-dtc.make index
586b098bc..e1625ef91 100644
--- a/rules/host-dtc.make
+++ b/rules/host-dtc.make
@@ -28,15 +28,17 @@ HOST_DTC_LICENSE	:= GPL-2.0-only
 # Prepare
 #
----------------------------------------------------------------------------
 
-HOST_DTC_CONF_TOOL := NO
-HOST_DTC_MAKE_OPT := \
+HOST_DTC_CONF_TOOL	:= NO
+
+HOST_DTC_MAKE_ENV	:= $(HOST_ENV)
+
+HOST_DTC_MAKE_OPT	:= \
 	PREFIX=/usr \
 	NO_PYTHON=1 \
 	NO_VALGRIND=1 \
-	NO_YAML=1 \
-	$(HOST_ENV_CC)
+	NO_YAML=1
 
-HOST_DTC_INSTALL_OPT := \
+HOST_DTC_INSTALL_OPT	:= \
 	$(HOST_DTC_MAKE_OPT) \
 	install-bin \
 	install-lib
--
2.39.2


[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 3908 bytes --]

Re: [ptxdist] [EXT] [PATCH] host-dtc: set make env

[Ladislav Michl]

Hi Denis,

On Mon, Jan 08, 2024 at 02:46:06PM +0100, Denis OSTERLAND-HEIM wrote:
> Hi,
> 
> what about using the target parameters here?
> HOST_DTC_MAKE_OPT = $(DTC_MAKE_OPT)
> HOST_DTC_INSTALL_OPT = $(DTC_INSTALL_OPT)

The equality is pure coincidence here, so making them the same could
cause troubes in the future if the need to change one of them arise.

Best regards,
	ladis

> Regards, Denis
> 
> -----Original Message-----
> From: ptxdist <ptxdist-bounces@pengutronix.de> On Behalf Of Ladislav Michl
> Sent: Friday, January 5, 2024 1:13 PM
> To: ptxdist@pengutronix.de
> Subject: [EXT] [ptxdist] [PATCH] host-dtc: set make env
> 
> [EXTERNAL EMAIL]
>  
> 
> From: Ladislav Michl <ladis@linux-mips.org>
> 
> Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> ---
>  rules/host-dtc.make | 12 +++++++-----
>  1 file changed, 7 insertions(+), 5 deletions(-)
> 
> diff --git a/rules/host-dtc.make b/rules/host-dtc.make index
> 586b098bc..e1625ef91 100644
> --- a/rules/host-dtc.make
> +++ b/rules/host-dtc.make
> @@ -28,15 +28,17 @@ HOST_DTC_LICENSE	:= GPL-2.0-only
>  # Prepare
>  #
> ----------------------------------------------------------------------------
>  
> -HOST_DTC_CONF_TOOL := NO
> -HOST_DTC_MAKE_OPT := \
> +HOST_DTC_CONF_TOOL	:= NO
> +
> +HOST_DTC_MAKE_ENV	:= $(HOST_ENV)
> +
> +HOST_DTC_MAKE_OPT	:= \
>  	PREFIX=/usr \
>  	NO_PYTHON=1 \
>  	NO_VALGRIND=1 \
> -	NO_YAML=1 \
> -	$(HOST_ENV_CC)
> +	NO_YAML=1
>  
> -HOST_DTC_INSTALL_OPT := \
> +HOST_DTC_INSTALL_OPT	:= \
>  	$(HOST_DTC_MAKE_OPT) \
>  	install-bin \
>  	install-lib
> --
> 2.39.2
> 

Re: [ptxdist] [EXT] [PATCH] host-dtc: set make env

[Michael Olbrich]

On Wed, Jan 10, 2024 at 07:40:45AM +0100, Ladislav Michl wrote:
> On Mon, Jan 08, 2024 at 02:46:06PM +0100, Denis OSTERLAND-HEIM wrote:
> > Hi,
> > 
> > what about using the target parameters here?
> > HOST_DTC_MAKE_OPT = $(DTC_MAKE_OPT)
> > HOST_DTC_INSTALL_OPT = $(DTC_INSTALL_OPT)
> 
> The equality is pure coincidence here, so making them the same could
> cause troubes in the future if the need to change one of them arise.

I agree. And there is also the problem, that PTXdist won't detect the
changes to trigger rebuilds. And it's not that much to make it worth it.

Michael

> Best regards,
> 	ladis
> 
> > Regards, Denis
> > 
> > -----Original Message-----
> > From: ptxdist <ptxdist-bounces@pengutronix.de> On Behalf Of Ladislav Michl
> > Sent: Friday, January 5, 2024 1:13 PM
> > To: ptxdist@pengutronix.de
> > Subject: [EXT] [ptxdist] [PATCH] host-dtc: set make env
> > 
> > [EXTERNAL EMAIL]
> >  
> > 
> > From: Ladislav Michl <ladis@linux-mips.org>
> > 
> > Signed-off-by: Ladislav Michl <ladis@linux-mips.org>
> > ---
> >  rules/host-dtc.make | 12 +++++++-----
> >  1 file changed, 7 insertions(+), 5 deletions(-)
> > 
> > diff --git a/rules/host-dtc.make b/rules/host-dtc.make index
> > 586b098bc..e1625ef91 100644
> > --- a/rules/host-dtc.make
> > +++ b/rules/host-dtc.make
> > @@ -28,15 +28,17 @@ HOST_DTC_LICENSE	:= GPL-2.0-only
> >  # Prepare
> >  #
> > ----------------------------------------------------------------------------
> >  
> > -HOST_DTC_CONF_TOOL := NO
> > -HOST_DTC_MAKE_OPT := \
> > +HOST_DTC_CONF_TOOL	:= NO
> > +
> > +HOST_DTC_MAKE_ENV	:= $(HOST_ENV)
> > +
> > +HOST_DTC_MAKE_OPT	:= \
> >  	PREFIX=/usr \
> >  	NO_PYTHON=1 \
> >  	NO_VALGRIND=1 \
> > -	NO_YAML=1 \
> > -	$(HOST_ENV_CC)
> > +	NO_YAML=1
> >  
> > -HOST_DTC_INSTALL_OPT := \
> > +HOST_DTC_INSTALL_OPT	:= \
> >  	$(HOST_DTC_MAKE_OPT) \
> >  	install-bin \
> >  	install-lib
> > --
> > 2.39.2
> > 
> 
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |