From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 10 Jan 2024 08:38:32 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rNTAW-00BLYw-0I for lore@lore.pengutronix.de; Wed, 10 Jan 2024 08:38:32 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rNTAV-0004X1-TW; Wed, 10 Jan 2024 08:38:31 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rNTAH-0004WM-56; Wed, 10 Jan 2024 08:38:17 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rNTAG-001eYd-Mv; Wed, 10 Jan 2024 08:38:16 +0100 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1rNTAG-009x5Q-21; Wed, 10 Jan 2024 08:38:16 +0100 Date: Wed, 10 Jan 2024 08:38:16 +0100 From: Michael Olbrich To: Ladislav Michl Message-ID: Mail-Followup-To: Ladislav Michl , ptxdist@pengutronix.de References: <15e64b2c1f794f3286baee2b9af3c243@diehl.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [EXT] [PATCH] host-dtc: set make env X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Wed, Jan 10, 2024 at 07:40:45AM +0100, Ladislav Michl wrote: > On Mon, Jan 08, 2024 at 02:46:06PM +0100, Denis OSTERLAND-HEIM wrote: > > Hi, > > > > what about using the target parameters here? > > HOST_DTC_MAKE_OPT = $(DTC_MAKE_OPT) > > HOST_DTC_INSTALL_OPT = $(DTC_INSTALL_OPT) > > The equality is pure coincidence here, so making them the same could > cause troubes in the future if the need to change one of them arise. I agree. And there is also the problem, that PTXdist won't detect the changes to trigger rebuilds. And it's not that much to make it worth it. Michael > Best regards, > ladis > > > Regards, Denis > > > > -----Original Message----- > > From: ptxdist On Behalf Of Ladislav Michl > > Sent: Friday, January 5, 2024 1:13 PM > > To: ptxdist@pengutronix.de > > Subject: [EXT] [ptxdist] [PATCH] host-dtc: set make env > > > > [EXTERNAL EMAIL] > > > > > > From: Ladislav Michl > > > > Signed-off-by: Ladislav Michl > > --- > > rules/host-dtc.make | 12 +++++++----- > > 1 file changed, 7 insertions(+), 5 deletions(-) > > > > diff --git a/rules/host-dtc.make b/rules/host-dtc.make index > > 586b098bc..e1625ef91 100644 > > --- a/rules/host-dtc.make > > +++ b/rules/host-dtc.make > > @@ -28,15 +28,17 @@ HOST_DTC_LICENSE := GPL-2.0-only > > # Prepare > > # > > ---------------------------------------------------------------------------- > > > > -HOST_DTC_CONF_TOOL := NO > > -HOST_DTC_MAKE_OPT := \ > > +HOST_DTC_CONF_TOOL := NO > > + > > +HOST_DTC_MAKE_ENV := $(HOST_ENV) > > + > > +HOST_DTC_MAKE_OPT := \ > > PREFIX=/usr \ > > NO_PYTHON=1 \ > > NO_VALGRIND=1 \ > > - NO_YAML=1 \ > > - $(HOST_ENV_CC) > > + NO_YAML=1 > > > > -HOST_DTC_INSTALL_OPT := \ > > +HOST_DTC_INSTALL_OPT := \ > > $(HOST_DTC_MAKE_OPT) \ > > install-bin \ > > install-lib > > -- > > 2.39.2 > > > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |