From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 28 Nov 2023 09:32:19 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1r7tVy-00Bvgc-1n for lore@lore.pengutronix.de; Tue, 28 Nov 2023 09:32:19 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1r7tVy-0001AF-To; Tue, 28 Nov 2023 09:32:18 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r7tVc-0001A5-1M; Tue, 28 Nov 2023 09:31:56 +0100 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r7tVb-00C86P-Kz; Tue, 28 Nov 2023 09:31:55 +0100 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1r7tVb-008djO-Bj; Tue, 28 Nov 2023 09:31:55 +0100 Date: Tue, 28 Nov 2023 09:31:55 +0100 From: Michael Olbrich To: Lars Pedersen Message-ID: Mail-Followup-To: Lars Pedersen , ptxdist@pengutronix.de References: <20231121072917.28820-1-lapeddk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231121072917.28820-1-lapeddk@gmail.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] networkmanager: Version bump 1.30.4 to 1.44.2 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Tue, Nov 21, 2023 at 08:29:17AM +0100, Lars Pedersen wrote: > dnssec_trigger and iptables configure options has been removed > > select PPP_MS_CHAP if NETWORKMANAGER_PPP is enabled to fix compile error: > ../NetworkManager-1.44.2/src/core/ppp/nm-pppd-compat.c:50:10: fatal > error: pppd/chap_ms.h: No such file or directory > 50 | #include > > Signed-off-by: Lars Pedersen > --- > Version 1.30.4 was getting pretty old and with this patch it will match > the one in Fedora 39. Surprisingly no major changes in configure > options. > > Note: Updating ppp to version 2.5.0 seemed pretty straight forward, but I > ran into issue https://github.com/ppp-project/ppp/issues/419. I'll try > to send a ppp patch when 2.5.1 is released. Hmmm, building fails with: FAILED: data/org.freedesktop.NetworkManager.policy .../sysroot-host/usr/bin/meson --internal msgfmthelper --msgfmt=.../sysroot-host/usr/bin/msgfmt data/org.freedesktop.NetworkManager.policy.in data/org.freedesktop.NetworkManager.policy xml .../build-target/NetworkManager-1.44.2/po .../sysroot-host/usr/bin/msgfmt: cannot locate ITS rules for data/org.freedesktop.NetworkManager.policy.in We're not selecting HOST_GETTEXT, so I'm guessing, msgfmt is found anyways even though it should not be used. But I've not looked any closer. Michael > rules/networkmanager.in | 1 + > rules/networkmanager.make | 6 ++---- > 2 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/rules/networkmanager.in b/rules/networkmanager.in > index e9af26729..8c5e8ad2e 100644 > --- a/rules/networkmanager.in > +++ b/rules/networkmanager.in > @@ -24,6 +24,7 @@ menuconfig NETWORKMANAGER > select POLKIT if NETWORKMANAGER_POLKIT > select PPP if NETWORKMANAGER_PPP > select PPP_PLUGINS if NETWORKMANAGER_PPP > + select PPP_MS_CHAP if NETWORKMANAGER_PPP > select READLINE if NETWORKMANAGER_NMCLI > select SYSTEMD if NETWORKMANAGER_SYSTEMD_UNIT > select UDEV > diff --git a/rules/networkmanager.make b/rules/networkmanager.make > index 9b47fadad..af310bd13 100644 > --- a/rules/networkmanager.make > +++ b/rules/networkmanager.make > @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_NETWORKMANAGER) += networkmanager > # > # Paths and names > # > -NETWORKMANAGER_VERSION := 1.30.4 > -NETWORKMANAGER_MD5 := 8ce53a38356864832f7f10ad46fcde27 > +NETWORKMANAGER_VERSION := 1.44.2 > +NETWORKMANAGER_MD5 := bd6c9cb0ecd0fb7f516cde7bf4dee3fb > NETWORKMANAGER := NetworkManager-$(NETWORKMANAGER_VERSION) > NETWORKMANAGER_SUFFIX := tar.xz > NETWORKMANAGER_URL := $(call ptx/mirror, GNOME, NetworkManager/$(basename $(NETWORKMANAGER_VERSION))/$(NETWORKMANAGER).$(NETWORKMANAGER_SUFFIX)) > @@ -47,7 +47,6 @@ NETWORKMANAGER_CONF_OPT = \ > -Ddhcpcanon=false \ > -Ddhcpcd=false \ > -Ddnsmasq=/usr/sbin/dnsmasq \ > - -Ddnssec_trigger=/bin/true \ > -Ddocs=false \ > -Debpf=false \ > -Dfirewalld_zone=false \ > @@ -55,7 +54,6 @@ NETWORKMANAGER_CONF_OPT = \ > -Difcfg_rh=false \ > -Difupdown=true \ > -Dintrospection=$(call ptx/truefalse,PTXCONF_NETWORKMANAGER_INTROSPECTION) \ > - -Diptables=/usr/sbin/iptables \ > -Diwd=false \ > -Dkernel_firmware_dir=/lib/firmware \ > -Dld_gc=true \ > -- > 2.41.0 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |