Re: [ptxdist] [PATCH] lighttpd: Version bump, 1.4.67 -> 1.4.72

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Tue, Oct 17, 2023 at 08:05:11AM +0200, Alexander Dahl wrote:
> Hello Andreas,
> 
> first of all, thanks for taking care of this, my remarks below.
> 
> Am Mon, Oct 16, 2023 at 07:07:34PM +0200 schrieb Andreas Helmcke:
> > Bugfixes and several changes. e.g.
> > - Stronger TLS defaults
> > - HTTP/2 Support now as optional module
> > 
> > see: https://www.lighttpd.net/releases/
> 
> Link: https://www.lighttpd.net/2023/1/3/1.4.68/
> Link: https://www.lighttpd.net/2023/2/10/1.4.69/
> Link: https://www.lighttpd.net/2023/5/10/1.4.70/
> Link: https://www.lighttpd.net/2023/5/27/1.4.71/
> Link: https://www.lighttpd.net/2023/10/6/1.4.72/
> 
> > Signed-off-by: Andreas Helmcke <ahelmcke@ela-soft.com>
> > ---
> >  rules/lighttpd.make | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/rules/lighttpd.make b/rules/lighttpd.make
> > index 3aa54a1fb..7b7abf7d2 100644
> > --- a/rules/lighttpd.make
> > +++ b/rules/lighttpd.make
> > @@ -15,8 +15,8 @@ PACKAGES-$(PTXCONF_LIGHTTPD) += lighttpd
> >  #
> >  # Paths and names
> >  #
> > -LIGHTTPD_VERSION	:= 1.4.67
> > -LIGHTTPD_MD5		:= 64822c5061001673162cf9775d91a80b
> > +LIGHTTPD_VERSION	:= 1.4.72
> > +LIGHTTPD_MD5		:= 466f9fe131cd7d38d0fe47d2e6a2939d
> 
> Builds fine, but …
> 
> That 1.4.70 in particular needs a little more work on the ptxdist
> package, because several modules are not built separate anymore, but
> built-in now.  This makes some of the LIGHTTPD_MOD_* options in menu
> not necessary anymore, and breaks targetinstall if those should have
> been installed before, e.g. like this:
> 
>     Error: ptxd_lib_install: cannot find library 'lighttpd/mod_indexfile'!
> 
> The list of affected modules is in the 1.4.70 announcement.
> 
> With 1.4.71 HTTP/2 support is moved to a separate module however and
> no longer built-in anymore.  Should we introduce a new menu option for
> that or let the ptxdist user configure it with
> PTXCONF_LIGHTTPD_MOD_EXTRA instead?

If it requires additional dependencies then a new option is mandatory.
If not, then I don't really care either way. Just leave it as is I guess.

Michael

> >  LIGHTTPD		:= lighttpd-$(LIGHTTPD_VERSION)
> >  LIGHTTPD_SUFFIX		:= tar.xz
> >  LIGHTTPD_URL		:= http://download.lighttpd.net/lighttpd/releases-1.4.x/$(LIGHTTPD).$(LIGHTTPD_SUFFIX)
> > -- 
> > 2.39.2
> > 
> > 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |