From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 26 May 2023 10:22:19 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q2SiK-00EoJ0-Qj for lore@lore.pengutronix.de; Fri, 26 May 2023 10:22:19 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q2SiH-0005Rm-So; Fri, 26 May 2023 10:22:17 +0200 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q2Si5-0005RU-9D; Fri, 26 May 2023 10:22:05 +0200 Received: from mol by pty.hi.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q2Si4-00EiEq-RF; Fri, 26 May 2023 10:22:04 +0200 Date: Fri, 26 May 2023 10:22:04 +0200 From: Michael Olbrich To: Philipp Zabel Message-ID: Mail-Followup-To: Philipp Zabel , ptxdist@pengutronix.de References: <20230526081735.1934247-1-p.zabel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230526081735.1934247-1-p.zabel@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] vulkan-loader: enable assembly on aarch64 and x86_64 X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, May 26, 2023 at 10:17:35AM +0200, Philipp Zabel wrote: > Signed-off-by: Philipp Zabel > --- > rules/vulkan-loader.make | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/rules/vulkan-loader.make b/rules/vulkan-loader.make > index 02981278de60..97c57dc21313 100644 > --- a/rules/vulkan-loader.make > +++ b/rules/vulkan-loader.make > @@ -45,8 +45,18 @@ VULKAN_LOADER_CONF_OPT := \ > -DLOADER_ENABLE_ADDRESS_SANITIZER=OFF \ > -DLOADER_ENABLE_THREAD_SANITIZER=OFF \ > -DSYSCONFDIR= \ > - -DUPDATE_DEPS=OFF \ > - -DUSE_GAS=OFF > + -DUPDATE_DEPS=OFF > + > +VULKAN_LOADER_USE_GAS := OFF > +ifdef PTXCONF_ARCH_ARM64 > +VULKAN_LOADER_USE_GAS := ON > +endif > +ifdef PTXCONF_ARCH_X86_64 > +VULKAN_LOADER_USE_GAS := ON > +endif Can you move this above the VULKAN_LOADER_CONF_OPT definition please. > + > +VULKAN_LOADER_CONF_OPT += \ > + -DUSE_GAS=$(VULKAN_LOADER_USE_GAS) And keep this in the listing above. Otherwise the order of the options is broken. Regards, Michael > > # ---------------------------------------------------------------------------- > # Target-Install > -- > 2.39.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |