From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH] vulkan-loader: enable assembly on aarch64 and x86_64
Date: Fri, 26 May 2023 10:22:04 +0200 [thread overview]
Message-ID: <ZHBsLJSl9Awk2mUt@pengutronix.de> (raw)
In-Reply-To: <20230526081735.1934247-1-p.zabel@pengutronix.de>
On Fri, May 26, 2023 at 10:17:35AM +0200, Philipp Zabel wrote:
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
> rules/vulkan-loader.make | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/rules/vulkan-loader.make b/rules/vulkan-loader.make
> index 02981278de60..97c57dc21313 100644
> --- a/rules/vulkan-loader.make
> +++ b/rules/vulkan-loader.make
> @@ -45,8 +45,18 @@ VULKAN_LOADER_CONF_OPT := \
> -DLOADER_ENABLE_ADDRESS_SANITIZER=OFF \
> -DLOADER_ENABLE_THREAD_SANITIZER=OFF \
> -DSYSCONFDIR= \
> - -DUPDATE_DEPS=OFF \
> - -DUSE_GAS=OFF
> + -DUPDATE_DEPS=OFF
> +
> +VULKAN_LOADER_USE_GAS := OFF
> +ifdef PTXCONF_ARCH_ARM64
> +VULKAN_LOADER_USE_GAS := ON
> +endif
> +ifdef PTXCONF_ARCH_X86_64
> +VULKAN_LOADER_USE_GAS := ON
> +endif
Can you move this above the VULKAN_LOADER_CONF_OPT definition please.
> +
> +VULKAN_LOADER_CONF_OPT += \
> + -DUSE_GAS=$(VULKAN_LOADER_USE_GAS)
And keep this in the listing above. Otherwise the order of the options is
broken.
Regards,
Michael
>
> # ----------------------------------------------------------------------------
> # Target-Install
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
prev parent reply other threads:[~2023-05-26 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 8:17 Philipp Zabel
2023-05-26 8:22 ` Michael Olbrich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZHBsLJSl9Awk2mUt@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=p.zabel@pengutronix.de \
--cc=ptxdist@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox