From: Michael Olbrich <m.olbrich@pengutronix.de>
To: Roland Hieber <rhi@pengutronix.de>, ptxdist@pengutronix.de
Subject: Re: [ptxdist] [PATCH 2/2] templates: set default section to hosttools_noprompt for host packages
Date: Wed, 17 May 2023 14:39:44 +0200 [thread overview]
Message-ID: <ZGTLEMLxvwPH1CBd@pengutronix.de> (raw)
In-Reply-To: <20230515080329.2027394-2-rhi@pengutronix.de>
On Mon, May 15, 2023 at 10:03:29AM +0200, Roland Hieber wrote:
> Most host packages are not meant to be selected by users, instead they
> are selected by target packages.
>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> scripts/lib/ptxd_lib_template.sh | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/lib/ptxd_lib_template.sh b/scripts/lib/ptxd_lib_template.sh
> index 6f91d8629b01..d77c4a73be8c 100644
> --- a/scripts/lib/ptxd_lib_template.sh
> +++ b/scripts/lib/ptxd_lib_template.sh
> @@ -106,7 +106,12 @@ ptxd_template_read_author() {
> export -f ptxd_template_read_author
>
> ptxd_template_read_section() {
> - local section_name="${1:-project_specific}"
> + local section_name
> + if [ "${action}" = "host" ]; then
> + section_name="${1:-hosttools_noprompt}"
We should remove the prompt in that case.
Michael
> + else
> + section_name="${1:-project_specific}"
> + fi
> ptxd_template_read "enter package section" section "${section_name}"
> }
> export -f ptxd_template_read_section
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-05-17 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 8:03 [ptxdist] [PATCH 1/2] templates: generate 'default y if ALLYES' " Roland Hieber
2023-05-15 8:03 ` [ptxdist] [PATCH 2/2] templates: set default section to hosttools_noprompt " Roland Hieber
2023-05-17 12:39 ` Michael Olbrich [this message]
2023-05-24 21:08 ` [ptxdist] [PATCH 3/2] templates: don't generate prompt for hosttools_noprompt packages Roland Hieber
2023-06-02 7:17 ` [ptxdist] [APPLIED] " Michael Olbrich
2023-06-02 7:17 ` [ptxdist] [APPLIED] templates: set default section to hosttools_noprompt for host packages Michael Olbrich
2023-06-02 7:17 ` [ptxdist] [APPLIED] templates: generate 'default y if ALLYES' " Michael Olbrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZGTLEMLxvwPH1CBd@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=ptxdist@pengutronix.de \
--cc=rhi@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox