From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 14 Apr 2023 12:09:04 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pnGMZ-003BoJ-CU for lore@lore.pengutronix.de; Fri, 14 Apr 2023 12:09:04 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pnGMZ-00058F-1y; Fri, 14 Apr 2023 12:09:03 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pnGMN-000586-To; Fri, 14 Apr 2023 12:08:51 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pnGMM-00BAYt-J1; Fri, 14 Apr 2023 12:08:50 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pnGML-00ELj1-Re; Fri, 14 Apr 2023 12:08:49 +0200 Date: Fri, 14 Apr 2023 12:08:49 +0200 From: Michael Olbrich To: Robin van der Gracht Message-ID: Mail-Followup-To: Robin van der Gracht , ptxdist@pengutronix.de References: <20230406145016.3074015-1-robin@protonic.nl> <20230406145016.3074015-3-robin@protonic.nl> <73e7824c-421b-a7f3-ea34-e46b591958b2@protonic.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73e7824c-421b-a7f3-ea34-e46b591958b2@protonic.nl> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH 3/3] rules: pcsc-lite: Add option for building with USB support X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Wed, Apr 12, 2023 at 09:56:18AM +0200, Robin van der Gracht wrote: > On 12-04-2023 08:32, Michael Olbrich wrote: > > On Thu, Apr 06, 2023 at 04:50:16PM +0200, Robin van der Gracht wrote: > > > Signed-off-by: Robin van der Gracht > > > --- > > > rules/pcsc-lite.in | 5 +++++ > > > rules/pcsc-lite.make | 2 +- > > > 2 files changed, 6 insertions(+), 1 deletion(-) > > > > > > diff --git a/rules/pcsc-lite.in b/rules/pcsc-lite.in > > > index 016a70037..de1c288c3 100644 > > > --- a/rules/pcsc-lite.in > > > +++ b/rules/pcsc-lite.in > > > @@ -18,6 +18,11 @@ menuconfig PCSC_LITE > > > if PCSC_LITE > > > +config PCSC_LITE_USB > > > + bool "USB Support" > > > + help > > > + Add USB support. > > > > Wrong indention. This should be tabs instead of spaces. I've fixed this > > while applying the patch. In the future, please run 'ptxdist lint' before > > sending patches. It will complain about all the small stuff like this. > > > > Ack. Thanks for pointing out the lint feature. Will do. Sorry, I dropped it. I looked at this again, and I don't think it needs an option. USB support by itself doesn't really do anything. From what I can tell, most of the code depends on either udev (we have an option for that) or libusb (that's disabled). So I think we can just enable USB unconditionally. Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |