From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 12 Apr 2023 08:43:17 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pmUCK-000nyR-MJ for lore@lore.pengutronix.de; Wed, 12 Apr 2023 08:43:17 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1pmUCJ-0005mh-RT; Wed, 12 Apr 2023 08:43:15 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pmUC8-0005mY-72; Wed, 12 Apr 2023 08:43:04 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pmUC7-00Aftu-Cw; Wed, 12 Apr 2023 08:43:03 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pmUC6-00EPuv-N8; Wed, 12 Apr 2023 08:43:02 +0200 Date: Wed, 12 Apr 2023 08:43:02 +0200 From: Michael Olbrich To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20230409080225.561083-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230409080225.561083-1-christian.melki@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] openssh: Disable config check in installation. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Sun, Apr 09, 2023 at 10:02:25AM +0200, Christian Melki wrote: > OpenSSH tries to run cross compiled target sshd on host > when installing. It uses the config validation function. > This gets an ugly install error (which ptxdist ignores?). Actually, it's the openssh buildsystem that ignored the error. Note the '-' as first character of the command. I'd rather not carry a patch. It cannot go upstream like this so we would have to keep it forever and its just cosmetic anyway. PTXdist never calls 'make' with '-i' to ignore errors. So if you find any explicitly ignored errors then the buildsystem of the package ignores the error. What's your usecase for this? Michael > Signed-off-by: Christian Melki > --- > ...0001-Makefile.in-Remove-check-config.patch | 25 +++++++++++++++++++ > patches/openssh-9.3p1/series | 4 +++ > 2 files changed, 29 insertions(+) > create mode 100644 patches/openssh-9.3p1/0001-Makefile.in-Remove-check-config.patch > create mode 100644 patches/openssh-9.3p1/series > > diff --git a/patches/openssh-9.3p1/0001-Makefile.in-Remove-check-config.patch b/patches/openssh-9.3p1/0001-Makefile.in-Remove-check-config.patch > new file mode 100644 > index 000000000..572e3d883 > --- /dev/null > +++ b/patches/openssh-9.3p1/0001-Makefile.in-Remove-check-config.patch > @@ -0,0 +1,25 @@ > +From: Christian Melki > +Date: Sat, 8 Apr 2023 10:12:02 +0200 > +Subject: [PATCH] Makefile.in: Remove check-config. > + > +OpenSSH tries to run target sshd on host when cross compiling. > +This results in an install failure. > + > +Signed-off-by: Christian Melki > +--- > + Makefile.in | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/Makefile.in b/Makefile.in > +index 70287f51fb81..0b131c92a781 100644 > +--- a/Makefile.in > ++++ b/Makefile.in > +@@ -377,7 +377,7 @@ distprep: catman-do depend-check > + $(AUTORECONF) > + -rm -rf autom4te.cache .depend.bak > + > +-install: $(CONFIGFILES) $(MANPAGES) $(TARGETS) install-files install-sysconf host-key check-config > ++install: $(CONFIGFILES) $(MANPAGES) $(TARGETS) install-files install-sysconf host-key > + install-nokeys: $(CONFIGFILES) $(MANPAGES) $(TARGETS) install-files install-sysconf > + install-nosysconf: $(CONFIGFILES) $(MANPAGES) $(TARGETS) install-files > + > diff --git a/patches/openssh-9.3p1/series b/patches/openssh-9.3p1/series > new file mode 100644 > index 000000000..b274d1052 > --- /dev/null > +++ b/patches/openssh-9.3p1/series > @@ -0,0 +1,4 @@ > +# generated by git-ptx-patches > +#tag:base --start-number 1 > +0001-Makefile.in-Remove-check-config.patch > +# e29227a4207a58013be625ec869e9ca7 - git-ptx-patches magic > -- > 2.34.1 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |