From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Sat, 08 Apr 2023 22:31:33 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1plFDg-00Ede3-4G for lore@lore.pengutronix.de; Sat, 08 Apr 2023 22:31:33 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1plFDg-0005mR-3b; Sat, 08 Apr 2023 22:31:32 +0200 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plFDA-0005lv-Js; Sat, 08 Apr 2023 22:31:00 +0200 Received: from rsc by pty.hi.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1plFD8-0062a3-R0; Sat, 08 Apr 2023 22:30:58 +0200 Date: Sat, 8 Apr 2023 22:30:58 +0200 From: Robert Schwebel To: ptxdist@pengutronix.de, christian.melki@t2data.com Message-ID: References: <20230404080026.4490-1-r.schwebel@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] openssl: add dependency to libatomic X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Sat, Apr 08, 2023 at 03:20:25PM +0200, Christian Melki wrote: > On 4/8/23 15:08, Robert Schwebel wrote: > > On Tue, Apr 04, 2023 at 10:00:26AM +0200, Robert Schwebel wrote: > >> Since openssl 3.x, libcrypto needs libatomic, at least on several 32 bit > >> platforms (and on 64 bit it doesn't harm). > >> > >> Signed-off-by: Robert Schwebel > >> --- > >> rules/openssl.in | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/rules/openssl.in b/rules/openssl.in > >> index 629ee3057..a86ca66a2 100644 > >> --- a/rules/openssl.in > >> +++ b/rules/openssl.in > >> @@ -4,6 +4,7 @@ menuconfig OPENSSL > >> tristate > >> select LIBC_DL > >> select GCCLIBS_GCC_S > >> + select GCCLIBS_ATOMIC > >> select CRYPTODEV_API if OPENSSL_CRYPTODEV && BUILDTIME > >> prompt "openssl " > >> help > > > > Hmm, with ptxdist-2023.04.0, I don't get the corresponding error any > > more (and instead a reason warning that libatomic is unused). Let's drop > > this for now. > > > > atomic is going to be highly dependent on toolchain, arch etc. > unless you're going to be more specific I suspect complains will happen > in both directions. True - now with the change removed, I see the issue on MIPS. Our "reason" checker now claims that /usr/lib/libcrypto.so.3 depends on libatomic.so.1 which is not there. v7a and v8a and x86_64 seem to be happy without it. > I'd be more interested why and where this pops up than adding a > blanket _ATOMIC. Ie. I agree on the drop. :) I'm a bit unsure what to do now :) rsc -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |