From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 13 Mar 2025 15:13:34 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tsjJW-00Db94-21 for lore@lore.pengutronix.de; Thu, 13 Mar 2025 15:13:34 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tsjJU-0006TF-C5; Thu, 13 Mar 2025 15:13:32 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tsjJH-0006SB-An; Thu, 13 Mar 2025 15:13:19 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tsjJG-005Y8m-2F; Thu, 13 Mar 2025 15:13:18 +0100 Received: from mtr by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tsjJG-00BNC5-1v; Thu, 13 Mar 2025 15:13:18 +0100 Date: Thu, 13 Mar 2025 15:13:18 +0100 From: Michael Tretter To: ptxdist@pengutronix.de Message-ID: References: <20250313093019.21911-1-benjamin.gaignard@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20250313093019.21911-1-benjamin.gaignard@collabora.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] Add drm_info package X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Benjamin Gaignard Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Thu, 13 Mar 2025 10:30:19 +0100, Benjamin Gaignard wrote: > Add Dpackag. for drm_info which is a small utility to dump > info about DRM devices. Thanks for the patch! > > Signed-off-by: Benjamin Gaignard > --- > rules/drm_info.in | 10 ++++++++++ > rules/drm_info.make | 32 ++++++++++++++++++++++++++++++++ > 2 files changed, 42 insertions(+) > create mode 100644 rules/drm_info.in > create mode 100644 rules/drm_info.make > > diff --git a/rules/drm_info.in b/rules/drm_info.in > new file mode 100644 > index 000000000..7346ec57e > --- /dev/null > +++ b/rules/drm_info.in > @@ -0,0 +1,10 @@ > +## SECTION=multimedia_libs Use multimedia_tools instead of multimedia_libs. > + > +menuconfig DRM_INFO > + tristate > + prompt "drm-info" > + select HOST_MESON select HOST_SYSTEM_PYTHON3 The meson.build calls the fourcc.py script during the build to generate the tables.c file. This needs python3 on the host system. > + select LIBDRM > + select JSON_C > + help > + Small utility to dump info about DRM devices. > diff --git a/rules/drm_info.make b/rules/drm_info.make > new file mode 100644 > index 000000000..d85242708 > --- /dev/null > +++ b/rules/drm_info.make > @@ -0,0 +1,32 @@ > + > +PACKAGES-$(PTXCONF_DRM_INFO) += drm_info Please add the copyright header. If you are using `ptxdist newpackage` to generate the new rule from the template, ptxdist will automatically add the header. > + > +DRM_INFO_VERSION := v2.7.0 Remove the "v". Using the version number without the v-prefix is more common in PTXdist. > +DRM_INFO_MD5 := 0066f5d02007b712d7b21a89e89785ba > +DRM_INFO := drm_info-$(DRM_INFO_VERSION) > +DRM_INFO_SUFFIX := tar.bz2 > +DRM_INFO_URL := https://gitlab.freedesktop.org/emersion/drm_info/-/archive/$(DRM_INFO_VERSION)/$(DRM_INFO_VERSION).$(DRM_INFO_SUFFIX) > +DRM_INFO_SOURCE := $(SRCDIR)/$(DRM_INFO).$(DRM_INFO_SUFFIX) > +DRM_INFO_DIR := $(BUILDDIR)/$(DRM_INFO) > +DRM_INFO_LICENSE := MIT Add DRM_INFO_LICENSE_FILES with the license file and md5 sum from the downloaded package. > + > +DRM_INFO_CONF_TOOL := meson > +DRM_INFO_OPT := $(CROSS_MESON_USR) DRM_INFO_OPT should be DRM_INFO_CONF_OPT. Also add the -Dlibpci=no and -Dman-pages=no options as reported by the configure_helper.py script. > + > +$(STATEDIR)/drm_info.install: > + @$(call targetinfo) > + @$(call world/install, DRM_INFO) > + > + @install -D -m644 $(DRM_INFO_DIR)-build/drm_info \ > + $(DRM_INFO_PKGDIR)/drm_info > + > + @$(call touch) Drop the install stage. The drm_info binary is already correctly installed into the PKGDIR by meson. > + > +$(STATEDIR)/drm_info.targetinstall: > + @$(call targetinfo) The header of the targetinstall stage is missing. It is generated by ptxdist newpackage and should be kept as information for the IPGK. Michael > + > + @$(call install_init, drm_info) > + @$(call install_copy, drm_info, 0, 0, 0755, -, /usr/bin/drm_info) > + @$(call install_finish, drm_info) > + > + @$(call touch) > -- > 2.43.0