Re: [ptxdist] [PATCH] mesalib: select HOST_SYSTEM_PYTHON3_PYYAML

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Sat, Feb 08, 2025 at 07:01:27PM +0100, Christian Melki wrote:
> I think you might have the same issue in host-mesalib?
> Don't know if that one needs more work though.

I had a quick look and technically should probably add the dependency
there as well.

Strictly, what we compile probably does not need it, but there is an
unconditional check in meson for it.
Right now it will never fail. We don't build host-mesalib without mesalib,
so the option is enabled. And we don't build PyYAML ourselfs. It's just a
check in host-system-python3. So there is no ordering issue.

But that may change in the future, so adding the dependency is the right
thing to do here.

Michael

> On 2/7/25 4:44 PM, Philipp Zabel wrote:
> > PyYAML is required to build Mesa since 24.2.0, mesa commit ccc6442d6f05
> > ("u_format: Rewrite format table to use YAML").
> > 
> > This issue was hidden before commit 1894396d091b ("host-system-python3:
> > use --system-site-packages only when needed") on build hosts that have
> > PyYAML installed system-wide.
> > 
> > Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> > ---
> >  rules/mesalib.in | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/rules/mesalib.in b/rules/mesalib.in
> > index ab83bbef70dd..83aab5f87c45 100644
> > --- a/rules/mesalib.in
> > +++ b/rules/mesalib.in
> > @@ -10,6 +10,7 @@ menuconfig MESALIB
> >  	select HOST_SYSTEM_PYTHON3
> >  	select HOST_SYSTEM_PYTHON3_MAKO
> >  	select HOST_SYSTEM_PYTHON3_PYCPARSER	if MESALIB_DRI_ETNAVIV
> > +	select HOST_SYSTEM_PYTHON3_PYYAML
> >  	select HOST_GLSLANG		if MESALIB_VULKAN_AMD
> >  	select HOST_GLSLANG		if MESALIB_VULKAN_INTEL
> >  	select HOST_GLSLANG		if MESALIB_VULKAN_OVERLAY
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |