From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 27 Jan 2025 11:46:29 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tcMdR-0054cG-0d for lore@lore.pengutronix.de; Mon, 27 Jan 2025 11:46:29 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tcMdR-00004q-Lo; Mon, 27 Jan 2025 11:46:29 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tcMdE-0008WG-Uc; Mon, 27 Jan 2025 11:46:16 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tcMdE-0026sn-2S; Mon, 27 Jan 2025 11:46:16 +0100 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tcMdE-00Gi5n-2B; Mon, 27 Jan 2025 11:46:16 +0100 Date: Mon, 27 Jan 2025 11:46:16 +0100 From: Michael Olbrich To: ptxdist@pengutronix.de Message-ID: Mail-Followup-To: ptxdist@pengutronix.de, Ahmad Fatoum References: <20250123205453.2841392-1-a.fatoum@pengutronix.de> <20250127083516.363301-1-m.olbrich@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250127083516.363301-1-m.olbrich@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-IRC: #ptxdist @freenode Subject: Re: [ptxdist] [APPLIED] util-linux: add option for building blkdiscard X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Ahmad Fatoum Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Mon, Jan 27, 2025 at 09:35:16AM +0100, Michael Olbrich wrote: > Thanks, applied as 9e0602b0e355efaf23b6306c813aa54630d101da. And as Jonas noted, I've now applied two patches for the same thing... I'll revert this one. Michael > [sent from post-receive hook] > > On Mon, 27 Jan 2025 09:35:16 +0100, Ahmad Fatoum wrote: > > We currently only have an option for BusyBox blkdiscard, but that one > > lacks some options like -z for zeroing the block device. > > > > This can be important as regular discard on an eMMC isn't guaranteed > > to clear data. > > > > Add a util-linux blkdiscard option to address this. > > > > Signed-off-by: Ahmad Fatoum > > Message-Id: <20250123205453.2841392-1-a.fatoum@pengutronix.de> > > Signed-off-by: Michael Olbrich > > > > diff --git a/rules/util-linux.in b/rules/util-linux.in > > index 58bd21100a9e..d883fb402ca2 100644 > > --- a/rules/util-linux.in > > +++ b/rules/util-linux.in > > @@ -62,6 +62,16 @@ config UTIL_LINUX_ADDPART > > help > > The addpart utility. > > > > +config UTIL_LINUX_BLKDISCARD > > + bool > > + depends on !BUSYBOX_BLKDISCARD || ALLYES > > + prompt "blkdiscard" > > + help > > + blkdiscard is used to discard device sectors. > > + > > +comment "BusyBox' blkdiscard is selected!" > > + depends on BUSYBOX_BLKDISCARD > > + > > config UTIL_LINUX_CFDISK > > bool > > select UTIL_LINUX_FDISKS > > diff --git a/rules/util-linux.make b/rules/util-linux.make > > index c98200a52258..143c7bcb78aa 100644 > > --- a/rules/util-linux.make > > +++ b/rules/util-linux.make > > @@ -197,6 +197,7 @@ UTIL_LINUX_LIB-$(PTXCONF_UTIL_LINUX_LIBFDISK) += fdisk > > > > # disk-utils > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_ADDPART) += sbin/addpart > > +UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_BLKDISCARD) += sbin/blkdiscard > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_CFDISK) += sbin/cfdisk > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_DELPART) += sbin/delpart > > UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_RESIZEPART) += sbin/resizepart > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |