Re: [ptxdist] [APPLIED] util-linux: add option for building blkdiscard

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Jan 27, 2025 at 09:35:16AM +0100, Michael Olbrich wrote:
> Thanks, applied as 9e0602b0e355efaf23b6306c813aa54630d101da.

And as Jonas noted, I've now applied two patches for the same thing... I'll
revert this one.

Michael

> [sent from post-receive hook]
> 
> On Mon, 27 Jan 2025 09:35:16 +0100, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote:
> > We currently only have an option for BusyBox blkdiscard, but that one
> > lacks some options like -z for zeroing the block device.
> > 
> > This can be important as regular discard on an eMMC isn't guaranteed
> > to clear data.
> > 
> > Add a util-linux blkdiscard option to address this.
> > 
> > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> > Message-Id: <20250123205453.2841392-1-a.fatoum@pengutronix.de>
> > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > 
> > diff --git a/rules/util-linux.in b/rules/util-linux.in
> > index 58bd21100a9e..d883fb402ca2 100644
> > --- a/rules/util-linux.in
> > +++ b/rules/util-linux.in
> > @@ -62,6 +62,16 @@ config UTIL_LINUX_ADDPART
> >  	help
> >  	  The addpart utility.
> >  
> > +config UTIL_LINUX_BLKDISCARD
> > +	bool
> > +	depends on !BUSYBOX_BLKDISCARD || ALLYES
> > +	prompt "blkdiscard"
> > +	help
> > +	  blkdiscard is used to discard device sectors.
> > +
> > +comment "BusyBox' blkdiscard is selected!"
> > +	depends on BUSYBOX_BLKDISCARD
> > +
> >  config UTIL_LINUX_CFDISK
> >  	bool
> >  	select UTIL_LINUX_FDISKS
> > diff --git a/rules/util-linux.make b/rules/util-linux.make
> > index c98200a52258..143c7bcb78aa 100644
> > --- a/rules/util-linux.make
> > +++ b/rules/util-linux.make
> > @@ -197,6 +197,7 @@ UTIL_LINUX_LIB-$(PTXCONF_UTIL_LINUX_LIBFDISK)		+= fdisk
> >  
> >  # disk-utils
> >  UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_ADDPART)		+= sbin/addpart
> > +UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_BLKDISCARD)		+= sbin/blkdiscard
> >  UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_CFDISK)		+= sbin/cfdisk
> >  UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_DELPART)		+= sbin/delpart
> >  UTIL_LINUX_BIN-$(PTXCONF_UTIL_LINUX_RESIZEPART)		+= sbin/resizepart
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |