From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 26 Nov 2024 09:36:36 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tFr3j-000YPd-25 for lore@lore.pengutronix.de; Tue, 26 Nov 2024 09:36:36 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1tFr3j-0001Gh-PI; Tue, 26 Nov 2024 09:36:35 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tFr3S-0001G2-Iy; Tue, 26 Nov 2024 09:36:18 +0100 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tFr3R-000DcV-1W; Tue, 26 Nov 2024 09:36:18 +0100 Received: from mol by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1tFr3S-00GYtY-0W; Tue, 26 Nov 2024 09:36:18 +0100 Date: Tue, 26 Nov 2024 09:36:18 +0100 From: Michael Olbrich To: "Christoph G. Baumann" Message-ID: Mail-Followup-To: "Christoph G. Baumann" , "ptxdist@pengutronix.de" References: <1507610582.167516.1732544788381@email.ionos.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1507610582.167516.1732544788381@email.ionos.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-IRC: #ptxdist @freenode Subject: Re: [ptxdist] PTXdist 2024.11.0 doesn't seem to check for already downloaded archives X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: "ptxdist@pengutronix.de" Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hi, On Mon, Nov 25, 2024 at 03:26:28PM +0100, Christoph G. Baumann wrote: > recently I wanted to upgrade my project to PTXdist 2024.11.0. > When rerunning a build I was surprised that the 'get' stage downloaded all the archives again despite them already being present in the src directory. > Then I tried to trace this in the files in scripts/lib. It boiled down to a line in scripts/lib/ptxd_make_world_get.sh. > According to 'git log' it was changed in this commit: > > commit ca7217db7bf2afe1104b074843403209f7f65aa3 > Author: Michael Olbrich > Date: Thu Mar 7 08:28:42 2024 +0100 > > ptxd_make_world_report_yaml: add source git commit if requested and available > Signed-off-by: Michael Olbrich > > When I restored the changed line to > "if [ -n "${pkg_src}" -a \( \! -e "${pkg_src}" -o "${ptxd_make_get_dryrun}" = "y" \) ]; then" > everything worked again as expected. > > Was this done intentionally? Yes, the same commit made this change in ptxd_make_get_http() in ptxd_make_get.sh: ------------ - else + elif [ ! -e "${path}" ]; then ------------ This skips the download if the file already exists. Maybe you have a local version of ptxd_make_get_http() in your BSP? Michael -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |