[ptxdist] PTXdist 2024.11.0 doesn't seem to check for already downloaded archives

[ptxdist] PTXdist 2024.11.0 doesn't seem to check for already downloaded archives

[Christoph G. Baumann]

Hello,

recently I wanted to upgrade my project to PTXdist 2024.11.0.
When rerunning a build I was surprised that the 'get' stage downloaded all the archives again despite them already being present in the src directory.
Then I tried to trace this in the files in scripts/lib. It boiled down to a line in scripts/lib/ptxd_make_world_get.sh.
According to 'git log' it was changed in this commit:

commit ca7217db7bf2afe1104b074843403209f7f65aa3
Author: Michael Olbrich <m.olbrich@pengutronix.de>
Date:   Thu Mar 7 08:28:42 2024 +0100

    ptxd_make_world_report_yaml: add source git commit if requested and available
    Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>

When I restored the changed line to
"if [ -n "${pkg_src}" -a \( \! -e "${pkg_src}" -o "${ptxd_make_get_dryrun}" = "y" \) ]; then"
everything worked again as expected.

Was this done intentionally?


Best regards,
Christoph

Re: [ptxdist] PTXdist 2024.11.0 doesn't seem to check for already downloaded archives

[Michael Olbrich]

Hi,

On Mon, Nov 25, 2024 at 03:26:28PM +0100, Christoph G. Baumann wrote:
> recently I wanted to upgrade my project to PTXdist 2024.11.0.
> When rerunning a build I was surprised that the 'get' stage downloaded all the archives again despite them already being present in the src directory.
> Then I tried to trace this in the files in scripts/lib. It boiled down to a line in scripts/lib/ptxd_make_world_get.sh.
> According to 'git log' it was changed in this commit:
> 
> commit ca7217db7bf2afe1104b074843403209f7f65aa3
> Author: Michael Olbrich <m.olbrich@pengutronix.de>
> Date:   Thu Mar 7 08:28:42 2024 +0100
> 
>     ptxd_make_world_report_yaml: add source git commit if requested and available
>     Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> 
> When I restored the changed line to
> "if [ -n "${pkg_src}" -a \( \! -e "${pkg_src}" -o "${ptxd_make_get_dryrun}" = "y" \) ]; then"
> everything worked again as expected.
> 
> Was this done intentionally?

Yes, the same commit made this change in ptxd_make_get_http() in
ptxd_make_get.sh:
------------
-    else
+    elif [ ! -e "${path}" ]; then
------------
This skips the download if the file already exists.

Maybe you have a local version of ptxd_make_get_http() in your BSP?

Michael

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [ptxdist] PTXdist 2024.11.0 doesn't seem to check for already downloaded archives

[Christoph G. Baumann]

Hello Michael,

> Michael Olbrich <m.olbrich@pengutronix.de> hat am 26.11.2024 09:36 CET geschrieben:
> [...]
> Yes, the same commit made this change in ptxd_make_get_http() in
> ptxd_make_get.sh:
> ------------
> -    else
> +    elif [ ! -e "${path}" ]; then
> ------------
> This skips the download if the file already exists.
>
> Maybe you have a local version of ptxd_make_get_http() in your BSP?

you are right. Some colleague snuck in a tampered, but obsolete version of ptxd_make_get.sh into the BSP.
Didn't know this could also be overridden :-)


Best regards,
Christoph