From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 22 Sep 2022 16:00:43 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1obMkt-00CDEM-AB for lore@lore.pengutronix.de; Thu, 22 Sep 2022 16:00:43 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1obMkr-000264-FJ; Thu, 22 Sep 2022 16:00:41 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1obMkU-00025J-5N; Thu, 22 Sep 2022 16:00:18 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1obMkU-002GWh-Tb; Thu, 22 Sep 2022 16:00:17 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1obMkS-00BH7j-Pl; Thu, 22 Sep 2022 16:00:16 +0200 Date: Thu, 22 Sep 2022 16:00:16 +0200 From: Michael Olbrich To: Marc Kleine-Budde Message-ID: Mail-Followup-To: Marc Kleine-Budde , ptxdist@pengutronix.de References: <20220920141759.3394460-1-mkl@pengutronix.de> <20220920141759.3394460-2-mkl@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220920141759.3394460-2-mkl@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH v2 1/7] libcurl: fix configure if no SSL backend is selected X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Tue, Sep 20, 2022 at 04:17:53PM +0200, Marc Kleine-Budde wrote: > If no SSL backend is selected configure will fail with the following > error: > > | configure: error: TLS not detected, you will not be able to use HTTPS, FTPS, NTLM and more. > | Use --with-openssl, --with-gnutls, --with-wolfssl, --with-mbedtls, > | --with-nss, --with-schannel, --with-secure-transport, --with-amissl, > | --with-bearssl or --with-rustls to address this. > > Fixes: 34db9dd470bd ("libcurl: Version bump. 7.84.0 -> 7.85.0") > Signed-off-by: Marc Kleine-Budde > --- > rules/libcurl.make | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/rules/libcurl.make b/rules/libcurl.make > index 0d0ac9ea33d0..1ddefa9a5b4e 100644 > --- a/rules/libcurl.make > +++ b/rules/libcurl.make > @@ -105,7 +105,6 @@ LIBCURL_CONF_OPT := \ > --without-brotli \ > --without-zstd \ > --without-gssapi \ > - --with-default-ssl-backend=$(PTXCONF_LIBCURL_SSL_DEFAULT_BACKEND) \ > --with-random=/dev/urandom \ > --with-ca-bundle=$(PTXCONF_LIBCURL_SSL_CABUNDLE_PATH) \ > --with-ca-path=$(PTXCONF_LIBCURL_SSL_CAPATH_PATH) \ > @@ -126,6 +125,14 @@ LIBCURL_CONF_OPT := \ > --without-zsh-functions-dir \ > --without-fish-functions-dir > > +ifdef PTXCONF_LIBCURL_SSL > +LIBCURL_CONF_OPT += \ > + --with-default-ssl-backend=$(PTXCONF_LIBCURL_SSL_DEFAULT_BACKEND) > +else > +LIBCURL_CONF_OPT += \ > + --without-ssl > +endif See my mail in the other thread. I don't think it needs to be this complex. Michael > + > # ---------------------------------------------------------------------------- > # Target-Install > # ---------------------------------------------------------------------------- > -- > 2.30.2 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |