Re: [ptxdist] [PATCH v1 2/5] add host libunsitring

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Sep 07, 2022 at 03:21:22PM +0200, Oleksij Rempel wrote:
> This package is needed by guile tools
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> ---
>  rules/host-libunistring.in   |  4 ++++
>  rules/host-libunistring.make | 38 ++++++++++++++++++++++++++++++++++++
>  2 files changed, 42 insertions(+)
>  create mode 100644 rules/host-libunistring.in
>  create mode 100644 rules/host-libunistring.make
> 
> diff --git a/rules/host-libunistring.in b/rules/host-libunistring.in
> new file mode 100644
> index 000000000..b501a8d12
> --- /dev/null
> +++ b/rules/host-libunistring.in
> @@ -0,0 +1,4 @@
> +## SECTION=hosttools_noprompt_ptx
> +
> +config HOST_LIBUNISTRING
> +	bool
> diff --git a/rules/host-libunistring.make b/rules/host-libunistring.make
> new file mode 100644
> index 000000000..21b14a57b
> --- /dev/null
> +++ b/rules/host-libunistring.make
> @@ -0,0 +1,38 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2022 by Marc Kleine-Budde <mkl@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +HOST_PACKAGES-$(PTXCONF_HOST_LIBUNISTRING) += host-libunistring
> +
> +#
> +# Paths and names
> +#
> +HOST_LIBUNISTRING_VERSION	:= 1.0
> +HOST_LIBUNISTRING_MD5	:= 88752c7859212f9c7a0f6cbf7a273535
> +HOST_LIBUNISTRING		:= libunistring-$(HOST_LIBUNISTRING_VERSION)
> +HOST_LIBUNISTRING_SUFFIX	:= tar.xz
> +HOST_LIBUNISTRING_URL	:= https://ftp.gnu.org/gnu/libunistring/$(HOST_LIBUNISTRING).$(HOST_LIBUNISTRING_SUFFIX)
> +HOST_LIBUNISTRING_SOURCE	:= $(SRCDIR)/$(HOST_LIBUNISTRING).$(HOST_LIBUNISTRING_SUFFIX)
> +HOST_LIBUNISTRING_DIR	:= $(HOST_BUILDDIR)/$(HOST_LIBUNISTRING)
> +HOST_LIBUNISTRING_LICENSE	:= GPLv3

This looks wrong. I've seen files with LGPLv2+ and (LGPLv3+ or GPLv2).
There may be others. And use SPDX identifiers and add the license files.

Michael

> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# autoconf
> +#
> +HOST_LIBUNISTRING_CONF_TOOL := autoconf
> +HOST_LIBUNISTRING_CONF_OPT :=  \
> +	$(HOST_AUTOCONF)
> +HOST_LIBUNISTRING_MAKE_OPT := V=1
> +
> +# vim: syntax=make
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |