From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 30 Aug 2022 09:23:47 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1oSvb9-001Ti0-86 for lore@lore.pengutronix.de; Tue, 30 Aug 2022 09:23:47 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1oSvb8-0008Ti-6E; Tue, 30 Aug 2022 09:23:46 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oSvan-0008TO-Uq; Tue, 30 Aug 2022 09:23:25 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1oSvan-002pFk-5i; Tue, 30 Aug 2022 09:23:25 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1oSvam-001nZ0-4H; Tue, 30 Aug 2022 09:23:24 +0200 Date: Tue, 30 Aug 2022 09:23:24 +0200 From: Michael Olbrich To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , Alexander Dahl , ptxdist@pengutronix.de References: <20220826133537.1843791-1-christian.melki@t2data.com> <2026849.Kn9BfFgYnX@ada> <979bfe94-2c54-bba5-a1e9-4337f863f7b0@t2data.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <979bfe94-2c54-bba5-a1e9-4337f863f7b0@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH 1/3] u-boot: Move u-boot URL to github. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: Alexander Dahl , ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, Aug 29, 2022 at 06:57:03PM +0200, Christian Melki wrote: > On 8/29/22 10:49, Alexander Dahl wrote: > > Hello Christian, > > > > Am Freitag, 26. August 2022, 15:35:35 CEST schrieb Christian Melki: > >> * Make URL configurable. Also. This aids in pointing > >> ptxdist to various vendor specific releases. > >> * Make compression format .tar.gz. Default > >> github contains such releases for really old releases, > >> so it should be fine. > >> * Bump default version to something more recent. > >> Just cosmetics really. > > > > What's the motivation for moving this to a mirror of the official sources? > > According to https://u-boot.readthedocs.io/en/latest/build/source.html the > > main and official forge is https://source.denx.de/u-boot/u-boot and > > additionally https://ftp.denx.de/pub/u-boot/ still contains all release > > tarballs up to the most recent RCs. This is also mentioned in the README in > > top level U-Boot source. > > > > Greets > > Alex > > > > The point beeing similarity between various vendor releases and vanilla > u-boot releases. But since the URL is configurable.. whichever really. > Github API has the advantage of being able to tell you about new > releases, should such a tool ever be adapted to ptxdist. Nack. Our u-boot package is already complex enough. I don't want to support whatever vendors do in their downstream repositories as well. Please create a local new package for that. I would be happy to accept a patch for a template to make this easier. Michael > I actually tried asking about github as an official source on irc, but > nobody cared to answer. > > regards, > C > > >> > >> Signed-off-by: Christian Melki > >> --- > >> platforms/u-boot.in | 11 +++++++++-- > >> rules/u-boot.make | 4 ++-- > >> 2 files changed, 11 insertions(+), 4 deletions(-) > >> > >> diff --git a/platforms/u-boot.in b/platforms/u-boot.in > >> index 769237081..8c7931d13 100644 > >> --- a/platforms/u-boot.in > >> +++ b/platforms/u-boot.in > >> @@ -9,13 +9,20 @@ menuconfig U_BOOT > >> > >> if U_BOOT > >> > >> +config U_BOOT_URL > >> + string > >> + default "https://github.com/u-boot/u-boot/releases/tag" > >> + prompt "U-Boot URL" > >> + help > >> + Enter the U-Boot URL you want to use. > >> + > >> config U_BOOT_VERSION > >> string > >> - default "2019.01" > >> + default "v2022.01" > >> prompt "U-Boot version" > >> help > >> Enter the U-Boot version you want to build. Usually something like > >> - "2019.01". > >> + "v2022.01". > >> > >> config U_BOOT_MD5 > >> string > >> diff --git a/rules/u-boot.make b/rules/u-boot.make > >> index cadca4a6b..1ba6d47b0 100644 > >> --- a/rules/u-boot.make > >> +++ b/rules/u-boot.make > >> @@ -19,8 +19,8 @@ PACKAGES-$(PTXCONF_U_BOOT) += u-boot > >> U_BOOT_VERSION := $(call ptx/config-version, PTXCONF_U_BOOT) > >> U_BOOT_MD5 := $(call ptx/config-md5, PTXCONF_U_BOOT) > >> U_BOOT := u-boot-$(U_BOOT_VERSION) > >> -U_BOOT_SUFFIX := tar.bz2 > >> -U_BOOT_URL := https://ftp.denx.de/pub/u-boot/$(U_BOOT).$(U_BOOT_SUFFIX) > >> +U_BOOT_SUFFIX := tar.gz > >> +U_BOOT_URL := $(PTXCONF_U_BOOT_URL)/$(U_BOOT_VERSION).$(U_BOOT_SUFFIX) > >> U_BOOT_SOURCE := $(SRCDIR)/$(U_BOOT).$(U_BOOT_SUFFIX) > >> U_BOOT_DIR := $(BUILDDIR)/$(U_BOOT) > >> U_BOOT_BUILD_DIR := $(U_BOOT_DIR)$(call ptx/ifdef, > >> PTXCONF_U_BOOT_BUILD_OOT,-build) > > > > > > > > > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |