Re: [ptxdist] [PATCH] xorg-lib-xcvt: new package

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Wed, Jul 06, 2022 at 05:20:08PM +0200, Lucas Stach wrote:
> libxcvt is a library providing a standalone version of the X server
> implementation of the VESA CVT standard timing modelines generator.
> 
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
>  rules/xorg-lib-xcvt.in   | 19 +++++++++++++
>  rules/xorg-lib-xcvt.make | 60 ++++++++++++++++++++++++++++++++++++++++

Please use libxcvt as package name. I've already done that with other
packages (e.g. libxcb). The xorg-* naming makes it hard to guess what the
package name will be, especially when it's not quite clear if a package is
Xorg only or is just historically related. Like, for example libxkbcommon.
So I stopped using such names for new packages.

Michael

>  2 files changed, 79 insertions(+)
>  create mode 100644 rules/xorg-lib-xcvt.in
>  create mode 100644 rules/xorg-lib-xcvt.make
> 
> diff --git a/rules/xorg-lib-xcvt.in b/rules/xorg-lib-xcvt.in
> new file mode 100644
> index 000000000000..51a326d4a383
> --- /dev/null
> +++ b/rules/xorg-lib-xcvt.in
> @@ -0,0 +1,19 @@
> +## SECTION=multimedia_xorg_lib
> +
> +config XORG_LIB_XCVT
> +	tristate
> +	select HOST_MESON
> +	prompt "libxcvt"
> +	help
> +	  libxcvt is a library providing a standalone version of the X server
> +	  implementation of the VESA CVT standard timing modelines generator.
> +
> +if XORG_LIB_XCVT
> +
> +config XORG_LIB_XCVT_TOOL
> +	bool
> +	prompt "install cvt cmdline tool"
> +	help
> +	  Install cvt commandline tool to generate CVT timings.
> +
> +endif
> diff --git a/rules/xorg-lib-xcvt.make b/rules/xorg-lib-xcvt.make
> new file mode 100644
> index 000000000000..483a7862da8e
> --- /dev/null
> +++ b/rules/xorg-lib-xcvt.make
> @@ -0,0 +1,60 @@
> +# -*-makefile-*-
> +#
> +# Copyright (C) 2022 by Lucas Stach <l.stach@pengutronix.de>
> +#
> +# For further information about the PTXdist project and license conditions
> +# see the README file.
> +#
> +
> +#
> +# We provide this package
> +#
> +PACKAGES-$(PTXCONF_XORG_LIB_XCVT) += xorg-lib-xcvt
> +
> +#
> +# Paths and names
> +#
> +XORG_LIB_XCVT_VERSION	:= 0.1.1
> +XORG_LIB_XCVT_MD5	:= 9f30247e8b5a09fa1df9538252a192b5
> +XORG_LIB_XCVT		:= libxcvt-$(XORG_LIB_XCVT_VERSION)
> +XORG_LIB_XCVT_SUFFIX	:= tar.xz
> +XORG_LIB_XCVT_URL	:= https://www.x.org/pub/individual/lib//$(XORG_LIB_XCVT).$(XORG_LIB_XCVT_SUFFIX)
> +XORG_LIB_XCVT_SOURCE	:= $(SRCDIR)/$(XORG_LIB_XCVT).$(XORG_LIB_XCVT_SUFFIX)
> +XORG_LIB_XCVT_DIR	:= $(BUILDDIR)/$(XORG_LIB_XCVT)
> +XORG_LIB_XCVT_LICENSE	:= MIT
> +XORG_LIB_XCVT_LICENSE_FILES := \
> +	file://COPYING;129947a06984d6faa6f9a9788fa2a03f
> +
> +# ----------------------------------------------------------------------------
> +# Prepare
> +# ----------------------------------------------------------------------------
> +
> +#
> +# meson
> +#
> +XORG_LIB_XCVT_CONF_TOOL	:= meson
> +
> +# ----------------------------------------------------------------------------
> +# Target-Install
> +# ----------------------------------------------------------------------------
> +
> +$(STATEDIR)/xorg-lib-xcvt.targetinstall:
> +	@$(call targetinfo)
> +
> +	@$(call install_init, xorg-lib-xcvt)
> +	@$(call install_fixup, xorg-lib-xcvt,PRIORITY,optional)
> +	@$(call install_fixup, xorg-lib-xcvt,SECTION,base)
> +	@$(call install_fixup, xorg-lib-xcvt,AUTHOR,"Lucas Stach <l.stach@pengutronix.de>")
> +	@$(call install_fixup, xorg-lib-xcvt,DESCRIPTION,missing)
> +
> +	@$(call install_lib, xorg-lib-xcvt, 0, 0, 0644, libxcvt)
> +
> +ifdef PTXCONF_XORG_LIB_XCVT_TOOL
> +	@$(call install_copy, xorg-lib-xcvt, 0, 0, 0755, -, /usr/bin/cvt)
> +endif
> +
> +	@$(call install_finish, xorg-lib-xcvt)
> +
> +	@$(call touch)
> +
> +# vim: syntax=make
> -- 
> 2.30.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |