From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 09 Jun 2022 20:54:31 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nzNId-0092cT-Hx for lore@lore.pengutronix.de; Thu, 09 Jun 2022 20:54:31 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nzNIc-0000vu-Pu; Thu, 09 Jun 2022 20:54:30 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nzNIF-0000vh-2d; Thu, 09 Jun 2022 20:54:07 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nzNIF-007Qqn-LC; Thu, 09 Jun 2022 20:54:06 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nzNID-00BTWA-7C; Thu, 09 Jun 2022 20:54:05 +0200 Date: Thu, 9 Jun 2022 20:54:05 +0200 From: Michael Olbrich To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20220607090350.346676-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220607090350.346676-1-christian.melki@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH 1/2] barebox: Simplify/cleanup barebox image installations. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Tue, Jun 07, 2022 at 11:03:49AM +0200, Christian Melki wrote: > Barebox has been carrying a descriptive barebox-flash-images file > for a while now. > This file contains the generated image files. > So instead of searching for images, let barebox tell us. > > Also remove some legacy image and environment handling. > This means that only Barebox >= 2015.12 is supported. > > Signed-off-by: Christian Melki > --- > rules/barebox.make | 35 ++++++++++------------------------- > 1 file changed, 10 insertions(+), 25 deletions(-) > > diff --git a/rules/barebox.make b/rules/barebox.make > index 753a47b59..581fd1ff9 100644 > --- a/rules/barebox.make > +++ b/rules/barebox.make > @@ -179,31 +179,16 @@ ifneq ($(strip $(BAREBOX_PROGS_TARGET_y)),) > endif > > @$(call world/image-clean, BAREBOX) > - @if [ -d $(BAREBOX_BUILD_DIR)/images ]; then \ > - find $(BAREBOX_BUILD_DIR)/images/ -name "barebox-*.img" | sort | while read image; do \ > - $(call ptx/image-install, BAREBOX, $$image); \ > - if [ ! -e $(IMAGEDIR)/barebox-image ]; then \ > - $(call ptx/image-install-link, BAREBOX, `basename $$image`, barebox-image); \ > - fi; \ > - done; \ > - fi > - @if [ -e $(IMAGEDIR)/barebox-image ]; then \ > - :; \ > - elif [ -e $(BAREBOX_BUILD_DIR)/barebox-flash-image ]; then \ > - $(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/barebox-flash-image, barebox-image); \ > - else \ > - $(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/barebox.bin, barebox-image); \ > - fi > - @if [ -e $(BAREBOX_BUILD_DIR)/defaultenv/barebox_zero_env ]; then \ > - $(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/defaultenv/barebox_zero_env, \ > - barebox-default-environment); \ > - elif [ -e $(BAREBOX_BUILD_DIR)/common/barebox_default_env ]; then \ > - $(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/common/barebox_default_env, \ > - barebox-default-environment); \ > - elif [ -e $(BAREBOX_BUILD_DIR)/barebox_default_env ]; then \ > - $(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/barebox_default_env, \ > - barebox-default-environment); \ > - fi > + For some reason I get "make: /usr/bin/bash: Argument list too long" with this now. Not sure why this didn't happen with the old version. Please do the following to fix that: > + @$(foreach image, $(shell cat $(BAREBOX_BUILD_DIR)/barebox-flash-images), \ > + $(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/$(image)); \ $(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/$(image))$(ptx/nl) \ > + if [ ! -e $(IMAGEDIR)/barebox-image ]; then \ > + $(call ptx/image-install-link, BAREBOX, $(notdir $(image)), barebox-image); \ > + fi; ) fi$(ptx/nl)) This creates multiple lines and the commands are executed separately. This shortens the argument list and the error is gone. As a side benefit, errors are no longer ignored. > + $(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/defaultenv/barebox_zero_env, \ > + barebox-default-environment); \ @$(call ptx/image-install, BAREBOX, $(BAREBOX_BUILD_DIR)/defaultenv/barebox_zero_env, \ barebox-default-environment) Michael > + > @$(call touch) > > # ---------------------------------------------------------------------------- > -- > 2.34.1 > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |