From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Fri, 29 Apr 2022 07:34:00 +0200
Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.94.2)
	(envelope-from <ptxdist-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1nkJGT-001fdV-Gy
	for lore@lore.pengutronix.de; Fri, 29 Apr 2022 07:34:00 +0200
Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de)
	by metis.ext.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <ptxdist-bounces@pengutronix.de>)
	id 1nkJGR-0004UJ-Ma; Fri, 29 Apr 2022 07:33:59 +0200
Received: from mail.thorsis.com ([92.198.35.195])
 by metis.ext.pengutronix.de with esmtp (Exim 4.92)
 (envelope-from <ada@thorsis.com>) id 1nkJFp-0004U3-Uz
 for ptxdist@pengutronix.de; Fri, 29 Apr 2022 07:33:22 +0200
Date: Fri, 29 Apr 2022 07:33:14 +0200
From: Alexander Dahl <ada@thorsis.com>
To: Ian Abbott <abbotti@mev.co.uk>
Message-ID: <Ymt4mnfUwue1Dd9D@ada-deb-carambola.ifak-system.com>
Mail-Followup-To: Ian Abbott <abbotti@mev.co.uk>, ptxdist@pengutronix.de
References: <bd93a0e8-f4eb-15ca-4078-9fdc28f89336@mev.co.uk>
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <bd93a0e8-f4eb-15ca-4078-9fdc28f89336@mev.co.uk>
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 metis.ext.pengutronix.de
X-Spam-Level: 
X-Spam-Status: No, score=-2.6 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE,
 SPF_PASS autolearn=ham autolearn_force=no version=3.4.2
Subject: Re: [ptxdist] dropbear and sftp-server mismatch
X-BeenThere: ptxdist@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: PTXdist Development Mailing List <ptxdist.pengutronix.de>
List-Unsubscribe: <http://metis.pengutronix.de/cgi-bin/mailman/options/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=unsubscribe>
List-Archive: <http://metis.pengutronix.de/cgi-bin/mailman/private/ptxdist/>
List-Post: <mailto:ptxdist@pengutronix.de>
List-Help: <mailto:ptxdist-request@pengutronix.de?subject=help>
List-Subscribe: <http://metis.pengutronix.de/cgi-bin/mailman/listinfo/ptxdist>, 
 <mailto:ptxdist-request@pengutronix.de?subject=subscribe>
Reply-To: ptxdist@pengutronix.de
Cc: ptxdist@pengutronix.de
Sender: "ptxdist" <ptxdist-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false

Hello Ian,

Am Thu, Apr 28, 2022 at 07:23:09PM +0100 schrieb Ian Abbott:
> Hi there,
> 
> Since scp now defaults to using the SFTP protocol which is not built in to
> dropbear, I thought I'd configure my platform to enable OPENSSH_SFTP_SERVER,
> but I ran into a 'gotcha'.  The server gets installed as
> "/usr/sbin/sftp-server" (and `--libexecdir` is configured as "/usr/sbin"),

This happens in the OpenSSH package, where libexecdir is configured as
/usr/sbin since 2003 … wow.

> but dropbear looks for it at "/usr/libexec/sftp-server".

Yes.

> The path to the sftp-server can be set in dropbear by defining the
> `SFTPSERVER_PATH` macro in "localoptions.h" file (constructed by
> "rules/dropbear.make").  That is not currently done, but is easy enough to
> add.  I was wondering whether it should be made configurable by a new option
> in "rules/dropbear.in" or not (using "/usr/sbin/sftp-server" as the default
> value).

I would tend to hardcode it into rules/dropbear.make … I don't see a
reason to have that as configurable menu option, do you?  Because we
probably won't change the path in openssh package, and to my knowledge
there's no alternative to the one from openssh?

Care to send a patch?

Greets
Alex