From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 11 Mar 2022 11:28:32 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nScVc-001rv2-Ra for lore@lore.pengutronix.de; Fri, 11 Mar 2022 11:28:32 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nScVc-0001IX-4V; Fri, 11 Mar 2022 11:28:32 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nScV3-0001IO-Rt; Fri, 11 Mar 2022 11:27:57 +0100 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nScV4-0001vt-Ba; Fri, 11 Mar 2022 11:27:56 +0100 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nScV2-00A0SK-7t; Fri, 11 Mar 2022 11:27:56 +0100 Date: Fri, 11 Mar 2022 11:27:56 +0100 From: Michael Olbrich To: Christian Melki , ptxdist@pengutronix.de Message-ID: Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20220226172857.4008318-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [PATCH] barebox: Remove all images from multi-image installs. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Fri, Mar 04, 2022 at 08:38:50AM +0100, Michael Olbrich wrote: > On Sat, Feb 26, 2022 at 06:28:57PM +0100, Christian Melki wrote: > > The multi-image install is a bit peculiar. > > It installs several target images and decides to softlink > > the last image to barebox-image, which is then used for image installs etc. > > The barebox-image only by chance pointing at the desired image. > > > > When removing images, only the softlink is removed. > > We could go with removal of barebox* but I find that a bit > > too indiscriminating. So add removal of anything called barebox-*.img. > > The problem is, that this may remove files from a different package. E.g. > from another barebox package, created with the barebox template. > > We should only delete files that we create. I have a vague idea about that. > Let me think about this some more. Take a look at ptxdist master. I've fixed this in a more generic way. Michael > > Signed-off-by: Christian Melki > > --- > > rules/barebox.make | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/rules/barebox.make b/rules/barebox.make > > index 1c8463e63..dc37e7a62 100644 > > --- a/rules/barebox.make > > +++ b/rules/barebox.make > > @@ -212,7 +212,7 @@ $(STATEDIR)/barebox.clean: > > @$(call clean_pkg, BAREBOX) > > @$(foreach prog, $(BAREBOX_PROGS_HOST), \ > > rm -vf $(PTXDIST_SYSROOT_HOST)/bin/$(notdir $(prog))$(ptx/nl)) > > - @rm -vf $(IMAGEDIR)/barebox-image $(IMAGEDIR)/barebox-default-environment > > + @rm -vf $(IMAGEDIR)/barebox-image $(IMAGEDIR)/barebox-*.img $(IMAGEDIR)/barebox-default-environment > > > > # ---------------------------------------------------------------------------- > > # oldconfig / menuconfig > > -- > > 2.30.2 > > > > > > _______________________________________________ > > ptxdist mailing list > > ptxdist@pengutronix.de > > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de