From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 11 Mar 2022 10:46:43 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nSbr9-001ppN-V3 for lore@lore.pengutronix.de; Fri, 11 Mar 2022 10:46:43 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nSbr9-0004tv-3G; Fri, 11 Mar 2022 10:46:43 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nSbqw-0004tK-Dx; Fri, 11 Mar 2022 10:46:30 +0100 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nSbqw-0001Tc-VO; Fri, 11 Mar 2022 10:46:29 +0100 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nSbqu-009GXI-Mv; Fri, 11 Mar 2022 10:46:28 +0100 Date: Fri, 11 Mar 2022 10:46:28 +0100 From: Michael Olbrich To: Christian Melki Message-ID: Mail-Followup-To: Christian Melki , ptxdist@pengutronix.de References: <20220310115612.1404060-1-christian.melki@t2data.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220310115612.1404060-1-christian.melki@t2data.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [ptxdist] [RFC: PATCH] u-boot: Add target name options. X-BeenThere: ptxdist@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: PTXdist Development Mailing List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: ptxdist@pengutronix.de Cc: ptxdist@pengutronix.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "ptxdist" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: ptxdist-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Thu, Mar 10, 2022 at 12:56:12PM +0100, Christian Melki wrote: > Add possibility to remove install of the normal u-boot.bin. > A lot of targets do not need it, some targets do not even build it > (Which generates an error during the install). > Add a i.mx8 family flash.bin image name. > > This entire thing bugs me a bit. > I don't really like the idea of a lot of target types just to copy files. > Usually I know what the target file is named and what I want it installed as > (which sometimes is a more generic name than the build name). > I can see this disappearing in favor of a more generic "copy this" "to this" with > the default names filled in and a help listing the typical binary target names > as a guideline. If feels a bit like whack a mole... That's one of the reasons why I prefer Barebox. I haven't seen anything but images/barebox-.img in a long time... > Signed-off-by: Christian Melki > --- > platforms/u-boot.in | 13 +++++++++++++ > rules/u-boot.make | 5 +++++ > 2 files changed, 18 insertions(+) > > diff --git a/platforms/u-boot.in b/platforms/u-boot.in > index c439e9c5d..56b96fb1e 100644 > --- a/platforms/u-boot.in > +++ b/platforms/u-boot.in > @@ -170,6 +170,13 @@ endif > > comment "target install" > > +config U_BOOT_INSTALL_U_BOOT_BIN > + prompt "install u-boot.bin" > + bool > + default true default y I'll fix it while applying. Michael > + help > + Installing the U-Boot default binary target. > + > config U_BOOT_INSTALL_SREC > prompt "install u-boot.srec" > bool > @@ -258,6 +265,12 @@ config U_BOOT_INSTALL_U_BOOT_STM32 > platform image directory. Say yes if you are building for STM32MP1 > SOCs. > > +config U_BOOT_INSTALL_U_BOOT_FLASH_BIN > + prompt "install flash.bin" > + bool > + help > + Installing the U-Boot image to Gateworks. > + > comment "build dependencies" > > config U_BOOT_NEEDS_HOST_OPENSSL > diff --git a/rules/u-boot.make b/rules/u-boot.make > index d127cf1e0..ac5a7786b 100644 > --- a/rules/u-boot.make > +++ b/rules/u-boot.make > @@ -139,7 +139,9 @@ $(STATEDIR)/u-boot.install: > $(STATEDIR)/u-boot.targetinstall: > @$(call targetinfo) > @$(call world/image-clean, U_BOOT) > +ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_BIN > @$(call ptx/image-install, U_BOOT, $(U_BOOT_BUILD_DIR)/u-boot.bin) > +endif > ifdef PTXCONF_U_BOOT_INSTALL_SREC > @$(call ptx/image-install, U_BOOT, $(U_BOOT_BUILD_DIR)/u-boot.srec) > endif > @@ -176,6 +178,9 @@ endif > ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_STM32 > @$(call ptx/image-install, U_BOOT, $(U_BOOT_BUILD_DIR)/u-boot.stm32) > endif > +ifdef PTXCONF_U_BOOT_INSTALL_U_BOOT_FLASH_BIN > + @$(call ptx/image-install, U_BOOT, $(U_BOOT_BUILD_DIR)/flash.bin) > +endif > ifndef PTXCONF_U_BOOT_ENV_IMAGE_NONE > @$(call ptx/image-install, U_BOOT, $(U_BOOT_BUILD_DIR)/u-boot-env.img) > endif > -- > 2.32.0 > > > _______________________________________________ > ptxdist mailing list > ptxdist@pengutronix.de > To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ ptxdist mailing list ptxdist@pengutronix.de To unsubscribe, send a mail with subject "unsubscribe" to ptxdist-request@pengutronix.de